From: <yang.yang29@zte.com.cn>
To: <willemdebruijn.kernel@gmail.com>
Cc: <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<pabeni@redhat.com>, <shuah@kernel.org>, <netdev@vger.kernel.org>,
<linux-kselftest@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<zhang.yunkai@zte.com.cn>, <xu.xin16@zte.com.cn>,
<jiang.xuexin@zte.com.cn>
Subject: Re: [PATCH linux-next v2] selftests: net: udpgso_bench_tx: Add test for IP fragmentation of UDP packets
Date: Fri, 3 Mar 2023 19:00:45 +0800 (CST) [thread overview]
Message-ID: <202303031900454292466@zte.com.cn> (raw)
In-Reply-To: <6400bd699f568_20743e2082b@willemb.c.googlers.com.notmuch>
> Did you actually observe a difference in behavior with this change?
The test of UDP only cares about sending, and does not much need to
consider the problem of PMTU, we configure it to IP_PMTUDISC_DONT.
IP_PMTUDISC_DONT: turn off pmtu detection.
IP_PMTUDISC_OMIT: the same as DONT, but in some scenarios, DF will
be ignored. I did not construct such a scene, presumably when forwarding.
Any way, in this test, is the same as DONT.
We have a question, what is the point of this test if it is not compared to
UDP GSO and IP fragmentation. No user or tool will segment in user mode,
UDP GSO should compare performance with IP fragmentation.
next prev parent reply other threads:[~2023-03-03 11:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-02 10:38 [PATCH linux-next v2] selftests: net: udpgso_bench_tx: Add test for IP fragmentation of UDP packets yang.yang29
2023-03-02 15:14 ` Willem de Bruijn
2023-03-03 11:00 ` yang.yang29 [this message]
2023-03-03 11:27 ` Eric Dumazet
2023-03-03 13:35 ` Willem de Bruijn
2023-03-06 7:31 ` xu xin
2023-03-06 14:35 ` Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202303031900454292466@zte.com.cn \
--to=yang.yang29@zte.com.cn \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jiang.xuexin@zte.com.cn \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=willemdebruijn.kernel@gmail.com \
--cc=xu.xin16@zte.com.cn \
--cc=zhang.yunkai@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).