From: kernel test robot <lkp@intel.com>
To: "Köry Maincent" <kory.maincent@bootlin.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-omap@vger.kernel.org
Cc: oe-kbuild-all@lists.linux.dev, Michael Walle <michael@walle.cc>,
Richard Cochran <richardcochran@gmail.com>,
Kory Maincent <kory.maincent@bootlin.com>,
thomas.petazzoni@bootlin.com, Jay Vosburgh <j.vosburgh@gmail.com>,
Veaceslav Falico <vfalico@gmail.com>,
Andy Gospodarek <andy@greyhouse.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Joakim Zhang <qiangqing.zhang@nxp.com>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
UNGLinuxDriver@microchip.com,
Grygorii Strashko <grygorii.strashko@ti.com>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Minghao Chi <chi.minghao@zte.com.cn>,
Jie Wang <wangjie125@huawei.com>,
Guangbin Huang <huangguangbin2@huawei.com>,
Wolfram Sang <wsa-dev@sang-engineering.com>,
Wang Yufen <wangyufen@huawei.com>,
Alexandru Tachici <alexandru.tachici@analog.com>,
Oleksij Rempel <linux@rempel-privat.de>
Subject: Re: [PATCH v2 3/4] net: Let the active time stamping layer be selectable.
Date: Sat, 4 Mar 2023 02:54:30 +0800 [thread overview]
Message-ID: <202303040219.nmNWbGrY-lkp@intel.com> (raw)
In-Reply-To: <20230303164248.499286-4-kory.maincent@bootlin.com>
Hi Köry,
I love your patch! Perhaps something to improve:
[auto build test WARNING on v6.2]
[also build test WARNING on next-20230303]
[cannot apply to net/master net-next/master horms-ipvs/master linus/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/K-ry-Maincent/net-ethtool-Refactor-identical-get_ts_info-implementations/20230304-004527
patch link: https://lore.kernel.org/r/20230303164248.499286-4-kory.maincent%40bootlin.com
patch subject: [PATCH v2 3/4] net: Let the active time stamping layer be selectable.
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20230304/202303040219.nmNWbGrY-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/00a0656f9b222cfeb7c1253a4a2771b1f63b5c9b
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review K-ry-Maincent/net-ethtool-Refactor-identical-get_ts_info-implementations/20230304-004527
git checkout 00a0656f9b222cfeb7c1253a4a2771b1f63b5c9b
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash net/core/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202303040219.nmNWbGrY-lkp@intel.com/
All warnings (new ones prefixed by >>):
net/core/net-sysfs.c: In function 'available_timestamping_providers_show':
net/core/net-sysfs.c:627:35: warning: variable 'ops' set but not used [-Wunused-but-set-variable]
627 | const struct ethtool_ops *ops;
| ^~~
net/core/net-sysfs.c: In function 'current_timestamping_provider_show':
>> net/core/net-sysfs.c:659:28: warning: variable 'phydev' set but not used [-Wunused-but-set-variable]
659 | struct phy_device *phydev;
| ^~~~~~
net/core/net-sysfs.c:657:35: warning: variable 'ops' set but not used [-Wunused-but-set-variable]
657 | const struct ethtool_ops *ops;
| ^~~
vim +/phydev +659 net/core/net-sysfs.c
90d54e1c6ed12a Richard Cochran 2023-03-03 652
90d54e1c6ed12a Richard Cochran 2023-03-03 653 static ssize_t current_timestamping_provider_show(struct device *dev,
90d54e1c6ed12a Richard Cochran 2023-03-03 654 struct device_attribute *attr,
90d54e1c6ed12a Richard Cochran 2023-03-03 655 char *buf)
90d54e1c6ed12a Richard Cochran 2023-03-03 656 {
90d54e1c6ed12a Richard Cochran 2023-03-03 657 const struct ethtool_ops *ops;
90d54e1c6ed12a Richard Cochran 2023-03-03 658 struct net_device *netdev;
90d54e1c6ed12a Richard Cochran 2023-03-03 @659 struct phy_device *phydev;
90d54e1c6ed12a Richard Cochran 2023-03-03 660 int ret;
90d54e1c6ed12a Richard Cochran 2023-03-03 661
90d54e1c6ed12a Richard Cochran 2023-03-03 662 netdev = to_net_dev(dev);
90d54e1c6ed12a Richard Cochran 2023-03-03 663 phydev = netdev->phydev;
90d54e1c6ed12a Richard Cochran 2023-03-03 664 ops = netdev->ethtool_ops;
90d54e1c6ed12a Richard Cochran 2023-03-03 665
90d54e1c6ed12a Richard Cochran 2023-03-03 666 if (!rtnl_trylock())
90d54e1c6ed12a Richard Cochran 2023-03-03 667 return restart_syscall();
90d54e1c6ed12a Richard Cochran 2023-03-03 668
00a0656f9b222c Richard Cochran 2023-03-03 669 switch (netdev->selected_timestamping_layer) {
00a0656f9b222c Richard Cochran 2023-03-03 670 case MAC_TIMESTAMPING:
90d54e1c6ed12a Richard Cochran 2023-03-03 671 ret = sprintf(buf, "%s\n", "mac");
00a0656f9b222c Richard Cochran 2023-03-03 672 break;
00a0656f9b222c Richard Cochran 2023-03-03 673 case PHY_TIMESTAMPING:
00a0656f9b222c Richard Cochran 2023-03-03 674 ret = sprintf(buf, "%s\n", "phy");
00a0656f9b222c Richard Cochran 2023-03-03 675 break;
90d54e1c6ed12a Richard Cochran 2023-03-03 676 }
90d54e1c6ed12a Richard Cochran 2023-03-03 677
90d54e1c6ed12a Richard Cochran 2023-03-03 678 rtnl_unlock();
90d54e1c6ed12a Richard Cochran 2023-03-03 679
90d54e1c6ed12a Richard Cochran 2023-03-03 680 return ret;
90d54e1c6ed12a Richard Cochran 2023-03-03 681 }
00a0656f9b222c Richard Cochran 2023-03-03 682
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
next prev parent reply other threads:[~2023-03-03 18:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-03 16:42 [PATCH v2 0/4] Up until now, there was no way to let the user select the layer at which time stamping occurs. The stack assumed that PHY time stamping is always preferred, but some MAC/PHY combinations were buggy Köry Maincent
2023-03-03 16:42 ` [PATCH v2 1/4] net: ethtool: Refactor identical get_ts_info implementations Köry Maincent
2023-03-03 16:42 ` [PATCH v2 2/4] net: Expose available time stamping layers to user space Köry Maincent
2023-03-03 18:13 ` kernel test robot
2023-03-03 23:52 ` Jakub Kicinski
2023-03-03 23:56 ` Willem de Bruijn
2023-03-03 16:42 ` [PATCH v2 3/4] net: Let the active time stamping layer be selectable Köry Maincent
2023-03-03 18:54 ` kernel test robot [this message]
2023-03-03 23:59 ` Willem de Bruijn
2023-03-04 15:04 ` Andrew Lunn
2023-03-04 3:06 ` kernel test robot
2023-03-04 15:43 ` Andrew Lunn
2023-03-04 16:16 ` Russell King (Oracle)
2023-03-04 19:46 ` Andrew Lunn
2023-03-06 17:55 ` Jakub Kicinski
2023-03-03 16:42 ` [PATCH v2 4/4] net: fix up drivers WRT phy time stamping Köry Maincent
2023-03-03 16:45 ` [PATCH v2 0/4] Up until now, there was no way to let the user select the layer at which time stamping occurs. The stack assumed that PHY time stamping is always preferred, but some MAC/PHY combinations were buggy Köry Maincent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202303040219.nmNWbGrY-lkp@intel.com \
--to=lkp@intel.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandru.tachici@analog.com \
--cc=andrew@lunn.ch \
--cc=andy@greyhouse.net \
--cc=chi.minghao@zte.com.cn \
--cc=claudiu.manoil@nxp.com \
--cc=edumazet@google.com \
--cc=grygorii.strashko@ti.com \
--cc=hkallweit1@gmail.com \
--cc=huangguangbin2@huawei.com \
--cc=j.vosburgh@gmail.com \
--cc=kory.maincent@bootlin.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linux@rempel-privat.de \
--cc=michael@walle.cc \
--cc=netdev@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=pabeni@redhat.com \
--cc=qiangqing.zhang@nxp.com \
--cc=richardcochran@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=vfalico@gmail.com \
--cc=vladimir.oltean@nxp.com \
--cc=wangjie125@huawei.com \
--cc=wangyufen@huawei.com \
--cc=wsa-dev@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).