From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82164C64EC4 for ; Sat, 4 Mar 2023 16:06:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229614AbjCDQG4 (ORCPT ); Sat, 4 Mar 2023 11:06:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45934 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229568AbjCDQGz (ORCPT ); Sat, 4 Mar 2023 11:06:55 -0500 Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 26FD4125AE for ; Sat, 4 Mar 2023 08:06:53 -0800 (PST) Received: by mail-pl1-x633.google.com with SMTP id i10so5828061plr.9 for ; Sat, 04 Mar 2023 08:06:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; t=1677946012; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=fNRPswH7mfojPgwky25vynoh6nRPOwNiJhCydmNShSY=; b=e2PDO04k4zwengrP5dDVN2NczXwr/lPLCrLm+yLJ1NSN1pTVvqiC2QPeQnzB06na06 UmWqvCRLk7Q3zRhlqU9C+8XlM5TA5ffhJy2L1ay5lh26/66JpUWhw68o14M/juuihdlt aKWyTVnVop3VoT97MPHepRXGuOJez2xOM19iQoRjS3GIcSBhIBv9sMaZ2M9xHWIS/lGQ axvEZ7GyjXkLqcHi9ucTXuFW2fv/nfH1y9R3IhahRjWa2bkJqJ+9RQVFzd2xNdeODm+f lvQO7+N/V59QnpGR1Ca5jKufu81iy1RT/92SPoqS/eKx/dFCmIEaDojgP9uriixxd+Zh oMYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677946012; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fNRPswH7mfojPgwky25vynoh6nRPOwNiJhCydmNShSY=; b=47tsFbKIECqdczV3Mpv9CQ2U/hkQ1p47OOz8YQm9t7A26Biblb74qk67zc4n+1eUXq g492DXj3+WnyyI8dn5mxQp0HCd940PPZkFMFVs+IHO30mNpxHeoWYKSGuzlTPWt2+vif g/HNsT4O5B54Sims75WlNKMc4m7NEMWpJrGbcjRLBnKk2BzTF8o53CqlzzQjHDAX/RNZ 4gC8+qF6qkS1XaFLlMj9GaDZXJDMb07j5cV3vQwaTZ0sWUi8Ofw0K/4/KwkUYv/sxR2j hCZF1oBw3xquwrh854Ecrqu+YXrkEAXx4IftPF1kxQ4ZAeRaIEoCijfbhWYxOrPDGxMZ Rwlw== X-Gm-Message-State: AO0yUKWydnAf/KfKLh+Kgioh3HAsWN15dzHs42nMkQXL5ij7E257Pn0x a+n8doG4wChZo5Jb6GizfdgFRA== X-Google-Smtp-Source: AK7set8yIGj/nV+mQtoOzSq/HVz1BnOBETpGChwHj8gVR5WIW0N3T7PwA9bRALL9ZeYmRPJ4+Gd84g== X-Received: by 2002:a17:90b:1b0c:b0:237:cfdb:c251 with SMTP id nu12-20020a17090b1b0c00b00237cfdbc251mr5353429pjb.16.1677946012543; Sat, 04 Mar 2023 08:06:52 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id gz7-20020a17090b0ec700b002349608e80csm3276373pjb.47.2023.03.04.08.06.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Mar 2023 08:06:52 -0800 (PST) Date: Sat, 4 Mar 2023 08:06:50 -0800 From: Stephen Hemminger To: Vincenzo Palazzo Cc: netdev@vger.kernel.org, davem@davemloft.net, intel-wired-lan@lists.osuosl.org, jesse.brandeburg@intel.com, khc@pm.waw.pl, kernel test robot Subject: Re: [PATCH v4] netdevice: use ifmap instead of plain fields Message-ID: <20230304080650.74e8d396@hermes.local> In-Reply-To: <20230304122432.265902-1-vincenzopalazzodev@gmail.com> References: <20230304122432.265902-1-vincenzopalazzodev@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, 4 Mar 2023 13:24:33 +0100 Vincenzo Palazzo wrote: > clean the code by using the ifmap instead of plain fields, > and avoid code duplication. > > v4 with some build error that the 0 day bot found while > compiling some drivers that I was not able to build on > my machine. > > Reported-by: kernel test robot > Link: https://lore.kernel.org/oe-kbuild-all/202303041847.nRrrz1v9-lkp@intel.com/ > Signed-off-by: Vincenzo Palazzo > --- Patching cadaver drivers is not worth it.