From: Fedor Pchelkin <pchelkin@ispras.ru>
To: Jakub Kicinski <kuba@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Guenter Roeck <groeck@google.com>,
Martin Faltesek <mfaltesek@google.com>,
Duoming Zhou <duoming@zju.edu.cn>,
Samuel Ortiz <sameo@linux.intel.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Alexey Khoroshilov <khoroshilov@ispras.ru>,
lvc-project@linuxtesting.org
Subject: Re: [PATCH] nfc: fix memory leak of se_io context in nfc_genl_se_io
Date: Sat, 4 Mar 2023 19:44:36 +0300 [thread overview]
Message-ID: <20230304164436.w57r7rwt26vnperl@fpc> (raw)
In-Reply-To: <20230227112359.6df702e3@kernel.org>
On Mon, Feb 27, 2023 at 11:23:59AM -0800, Jakub Kicinski wrote:
> FWIW this patch has already been applied, please send the next changes
> on top:
> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=25ff6f8a5a3b8dc48e8abda6f013e8cc4b14ffea
Okay.
On Mon, Feb 27, 2023 at 11:08:54AM +0100, Krzysztof Kozlowski wrote:
> kfree could be after device_unlock. Although se_io() will free it with
> lock held, but error paths usually unwind everything in reverse order
> LIFO, so first unlock then kfree.
Then, based on our dicsussion with Krzysztof, I'll send the patch
adjusting the order in the error path.
prev parent reply other threads:[~2023-03-04 16:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-25 10:56 [PATCH] nfc: fix memory leak of se_io context in nfc_genl_se_io Fedor Pchelkin
2023-02-27 10:08 ` Krzysztof Kozlowski
2023-02-27 15:05 ` Fedor Pchelkin
2023-02-28 10:14 ` Krzysztof Kozlowski
2023-02-28 11:25 ` Fedor Pchelkin
2023-03-06 15:27 ` Krzysztof Kozlowski
2023-02-27 19:23 ` Jakub Kicinski
2023-03-04 16:44 ` Fedor Pchelkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230304164436.w57r7rwt26vnperl@fpc \
--to=pchelkin@ispras.ru \
--cc=davem@davemloft.net \
--cc=duoming@zju.edu.cn \
--cc=edumazet@google.com \
--cc=groeck@google.com \
--cc=khoroshilov@ispras.ru \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=mfaltesek@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).