From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84582C64EC4 for ; Mon, 6 Mar 2023 18:00:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229782AbjCFSAl (ORCPT ); Mon, 6 Mar 2023 13:00:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58180 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229748AbjCFSAj (ORCPT ); Mon, 6 Mar 2023 13:00:39 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A28226BDEE for ; Mon, 6 Mar 2023 09:59:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678125510; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sha45Z6kxUfGCsHlDwTHYO9Fd2D72roLvFwFgZw/FPE=; b=DQ92DTpVxa/8p85mI/0qv7RQF6ESJFUd/L6P0hQnFL/jRh+wZorLFEMVbtxuEkO7Uq0Xvu OnUGrwghFG6PFKP1hPNouv5ffa8NwCBYVZq/QNbN7ybDatz39S8nx4VgBy4QMqJU9UM6jO C/bN7yDBYtvQoZ+9vRDo2b1HRZI8RFs= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-567-SwDxQ7BhMQ6LVSpECuH1Zg-1; Mon, 06 Mar 2023 12:58:28 -0500 X-MC-Unique: SwDxQ7BhMQ6LVSpECuH1Zg-1 Received: by mail-wm1-f71.google.com with SMTP id s18-20020a7bc392000000b003deaf780ab6so4055715wmj.4 for ; Mon, 06 Mar 2023 09:58:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678125507; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=sha45Z6kxUfGCsHlDwTHYO9Fd2D72roLvFwFgZw/FPE=; b=QsRaKaPclAY/CbStqJXJrnchIRIsXBIVCR5Z/59eJk7z9YfOs8W+Jba4Y0Fl/lSB0R UdyQu0DwyJlQUxBR6p+hVaUE/o1pUe7zeGFvzSjhPQ9xo6/DigOJm2H+SV2WsLuWBGNI lKUXCpYoHIna8A2ZpmyUGhBSmYoIWPkIw5hU47PG23Xa1LHQRYVn7sLtBjYlHWOspSw6 JsQE4FVHmb4/QpLc55FOveJ3WKIwQc6BKV7qdR80NLtbGz/8F+MKTNPRWesUbAVhaqaM Gfueuk8OdpLcIzyTVQpfVaiweuE0L1VKfNtoXu1WHyu8/PZ6cMVomWf/qhqcZZpzk1m4 5Ahg== X-Gm-Message-State: AO0yUKWjFlM4KkkgrNNlmC8Up7wFozhLVs++i0B3c9WYhDP54M4EZ9b7 n9oDi1N5XPT4XDgD89eMMiRP94mZHzpbHjtPiYIMbjmWyH7zEcGKAtwH7faH2jfogjTXCz6bpgW 0pOQMehygTdW6akLC X-Received: by 2002:a5d:4c4b:0:b0:2c9:3955:3948 with SMTP id n11-20020a5d4c4b000000b002c939553948mr7190649wrt.70.1678125507608; Mon, 06 Mar 2023 09:58:27 -0800 (PST) X-Google-Smtp-Source: AK7set/ZqnKJ/0nA9TbgFwZk42oznbVt+r2kcV8jDYft1m0CV33kw5zk5T7j0SazRpSbiKjkf+BORw== X-Received: by 2002:a5d:4c4b:0:b0:2c9:3955:3948 with SMTP id n11-20020a5d4c4b000000b002c939553948mr7190630wrt.70.1678125507339; Mon, 06 Mar 2023 09:58:27 -0800 (PST) Received: from redhat.com ([2.52.23.160]) by smtp.gmail.com with ESMTPSA id c10-20020adffb0a000000b002ce72cff2ecsm849606wrr.72.2023.03.06.09.58.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Mar 2023 09:58:26 -0800 (PST) Date: Mon, 6 Mar 2023 12:58:22 -0500 From: "Michael S. Tsirkin" To: Xuan Zhuo Cc: netdev@vger.kernel.org, Jason Wang , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , virtualization@lists.linux-foundation.org, bpf@vger.kernel.org Subject: Re: [PATCH net 0/2] add checking sq is full inside xdp xmit Message-ID: <20230306125742-mutt-send-email-mst@kernel.org> References: <20230306041535.73319-1-xuanzhuo@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230306041535.73319-1-xuanzhuo@linux.alibaba.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Mar 06, 2023 at 12:15:33PM +0800, Xuan Zhuo wrote: > If the queue of xdp xmit is not an independent queue, then when the xdp > xmit used all the desc, the xmit from the __dev_queue_xmit() may encounter > the following error. > > net ens4: Unexpected TXQ (0) queue failure: -28 > > This patch adds a check whether sq is full in XDP Xmit. > > Thanks. Acked-by: Michael S. Tsirkin needed for stable? > Xuan Zhuo (2): > virtio_net: separate the logic of checking whether sq is full > virtio_net: add checking sq is full inside xdp xmit > > drivers/net/virtio_net.c | 78 ++++++++++++++++++++++++---------------- > 1 file changed, 47 insertions(+), 31 deletions(-) > > -- > 2.32.0.3.g01195cf9f