From: Jakub Kicinski <kuba@kernel.org>
To: Fedor Pchelkin <pchelkin@ispras.ru>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Alexey Khoroshilov <khoroshilov@ispras.ru>,
lvc-project@linuxtesting.org
Subject: Re: [PATCH] nfc: change order inside nfc_se_io error path
Date: Mon, 6 Mar 2023 12:58:42 -0800 [thread overview]
Message-ID: <20230306125842.7fea0be5@kernel.org> (raw)
In-Reply-To: <20230306204150.vjpgqbau3kogg4n3@fpc>
On Mon, 6 Mar 2023 23:41:50 +0300 Fedor Pchelkin wrote:
> On Mon, Mar 06, 2023 at 11:35:09PM +0300, Fedor Pchelkin wrote:
> > On Mon, Mar 06, 2023 at 04:28:12PM +0100, Krzysztof Kozlowski wrote:
> > > I would argue that it is functional. Running code in or outside of
> > > critical section/locks is quite functional change.
> > >
> >
> > Hmm, actually, yes. I'll resend v2 with changed commit info as 'no
> > functional changes' statement can probably be misunderstood later.
> >
> > Should this patch be backported by the way? It doesn't seem to fix any
> > real issue but, as you mentioned, it contains some functional changes
> > which may be of some importance in future.
>
> Sorry for the noise. Didn't see the patch was already applied. So it's
> okay as it is.
As luck would have it it was applied to the wrong branch (we use main,
not master now). Script malfunction perhaps. So I'll toss it, you can
send a v2 with the updated commit message, please.
next prev parent reply other threads:[~2023-03-06 20:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-04 16:48 [PATCH] nfc: change order inside nfc_se_io error path Fedor Pchelkin
2023-03-06 15:28 ` Krzysztof Kozlowski
2023-03-06 20:35 ` Fedor Pchelkin
2023-03-06 20:41 ` Fedor Pchelkin
2023-03-06 20:58 ` Jakub Kicinski [this message]
2023-03-06 21:26 ` [PATCH v2] " Fedor Pchelkin
2023-03-07 9:19 ` Krzysztof Kozlowski
2023-03-07 21:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230306125842.7fea0be5@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=khoroshilov@ispras.ru \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pchelkin@ispras.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).