From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8517CC6FD1A for ; Tue, 7 Mar 2023 16:05:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229653AbjCGQFn (ORCPT ); Tue, 7 Mar 2023 11:05:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51584 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230077AbjCGQEi (ORCPT ); Tue, 7 Mar 2023 11:04:38 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8BA01A1031 for ; Tue, 7 Mar 2023 08:01:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678204796; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=I0FHpHDfgMNKIF0PugEg3oYZEslsm/Wba3C2OVAQmj8=; b=FMPY491LINJnLCwbzZoBO1VXKcbaV/sFyqobeFvZEuqaDgY5N5Ug5Oafga/fpZQaXapDRN 3nBqLFzeTi2eU5b7+V+OdsTOnjiYO3Hxwr3ob/h2n64K2mcI3UF3X+dZpHbtT52n3Rrh7g 8HXhswlD/HUuLRHt/sv9pRdshEChfFE= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-260-C3tjf3oKORChP-BYBxEjzg-1; Tue, 07 Mar 2023 10:59:54 -0500 X-MC-Unique: C3tjf3oKORChP-BYBxEjzg-1 Received: by mail-wm1-f69.google.com with SMTP id r7-20020a05600c35c700b003eb3f2c4fb4so5131936wmq.6 for ; Tue, 07 Mar 2023 07:59:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678204793; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=I0FHpHDfgMNKIF0PugEg3oYZEslsm/Wba3C2OVAQmj8=; b=Ry9D2HpS9iCvizE3n2n8Xa+upKZ6S0aM/v/0J4DcHAoFnaasYIIMiXuPmcTUsJVJ8O PmcbTUf22RCJZXCjO9UqnjAR9rjVjE4Im9lezF/Ml+v11EXCW7fXXv5Fvkwb+GEsfUm/ lUJUSFpg/9Evio65EisrSDE0S1P5lR/pEBjLISaPE8jVwUdw4pMORBbG/+nKYdI5dOPG 65hoSyM49HMAhuJeF6+HuaSVNa5MSzfNQEDV/QuHfoh8qrENQSjIRCEHoH2dSl/Y4X+5 absLEk3a2CjIRJSamfQDAEjS6CgOvXw/Kt2Ed0DgeXueWs445eQzIpG7Z1qHyppe8Qxt 7rTg== X-Gm-Message-State: AO0yUKXIITcvpOkEkynMCILFlni/Ap+bY/ZsevTkfD0cEA1lFXgaeAgo bpf0CxRgl3M8YwtJv7OW+ny2lQ0FJWyv+usmFeQ0ye1EwziRX0c2KUCObXitPRWr2LeUaXNK5Ec p/XA86Xq+qcyztJoTEfcf4aQA X-Received: by 2002:a05:600c:4708:b0:3ea:e7e7:95d9 with SMTP id v8-20020a05600c470800b003eae7e795d9mr13611740wmo.32.1678204792809; Tue, 07 Mar 2023 07:59:52 -0800 (PST) X-Google-Smtp-Source: AK7set9ob27rJ5Fb3HgQd1GlfrWD/oV9eHzxuYT1BLvurc5s6TprDFYyhGudmqSQfuT1fPyQzYHBIQ== X-Received: by 2002:a05:600c:4708:b0:3ea:e7e7:95d9 with SMTP id v8-20020a05600c470800b003eae7e795d9mr13611707wmo.32.1678204792450; Tue, 07 Mar 2023 07:59:52 -0800 (PST) Received: from redhat.com ([2.52.138.216]) by smtp.gmail.com with ESMTPSA id n37-20020a05600c3ba500b003e2052bad94sm19010162wms.33.2023.03.07.07.59.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Mar 2023 07:59:51 -0800 (PST) Date: Tue, 7 Mar 2023 10:59:47 -0500 From: "Michael S. Tsirkin" To: Paolo Abeni Cc: Xuan Zhuo , netdev@vger.kernel.org, Jason Wang , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , virtualization@lists.linux-foundation.org, bpf@vger.kernel.org Subject: Re: [PATCH net 0/2] add checking sq is full inside xdp xmit Message-ID: <20230307105848-mutt-send-email-mst@kernel.org> References: <20230306041535.73319-1-xuanzhuo@linux.alibaba.com> <20230306125742-mutt-send-email-mst@kernel.org> <1678153770.8281553-2-xuanzhuo@linux.alibaba.com> <27a06a7d79fef3446ae1167612808a2af09922be.camel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <27a06a7d79fef3446ae1167612808a2af09922be.camel@redhat.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Mar 07, 2023 at 10:53:41AM +0100, Paolo Abeni wrote: > Hi, > On Tue, 2023-03-07 at 09:49 +0800, Xuan Zhuo wrote: > > On Mon, 6 Mar 2023 12:58:22 -0500, "Michael S. Tsirkin" wrote: > > > On Mon, Mar 06, 2023 at 12:15:33PM +0800, Xuan Zhuo wrote: > > > > If the queue of xdp xmit is not an independent queue, then when the xdp > > > > xmit used all the desc, the xmit from the __dev_queue_xmit() may encounter > > > > the following error. > > > > > > > > net ens4: Unexpected TXQ (0) queue failure: -28 > > > > > > > > This patch adds a check whether sq is full in XDP Xmit. > > > > > > > > Thanks. > > > > > > Acked-by: Michael S. Tsirkin > > > > > > needed for stable? > > > > Yes i think. > > Could you please re-post including a suitable 'Fixes' tag? That would > address stable, too. Additionally you could rename check_sq_full() in > patch 1, perhaps 'check_disable_sq_full()' would do. Not that's even more confusing it sounds like it's checking that it's checking that sq is disabled unless one looks closely. I think check_sq_full_and_disable() is better. > You can retain the already collected tags. > > Thanks! > > Paolo