From: Jakub Kicinski <kuba@kernel.org>
To: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: davem@davemloft.net, pabeni@redhat.com, edumazet@google.com,
netdev@vger.kernel.org,
Tirthendu Sarkar <tirthendu.sarkar@intel.com>,
maciej.fijalkowski@intel.com, magnus.karlsson@intel.com,
ast@kernel.org, daniel@iogearbox.net, hawk@kernel.org,
john.fastabend@gmail.com, bpf@vger.kernel.org,
Chandan Kumar Rout <chandanx.rout@intel.com>
Subject: Re: [PATCH net-next 2/8] i40e: change Rx buffer size for legacy-rx to support XDP multi-buffer
Date: Tue, 7 Mar 2023 18:18:29 -0800 [thread overview]
Message-ID: <20230307181829.5dcec646@kernel.org> (raw)
In-Reply-To: <20230306210822.3381942-3-anthony.l.nguyen@intel.com>
On Mon, 6 Mar 2023 13:08:16 -0800 Tony Nguyen wrote:
> In the legacy-rx mode, driver can only configure up to 2k sized Rx buffers
> and with the current configuration of 2k sized Rx buffers there is no way
> to do tailroom reservation for skb_shared_info. Hence size of Rx buffers
> is now lowered to 1664 (2k - sizeof(skb_shared_info)). Also, driver can
skb_shared_info is not fixed size, the number of fragments can
be changed in the future. What will happen to the driver and
this assumption, then?
> only chain up to 5 Rx buffers and this means max MTU supported for
> legacy-rx is now 8320.
next prev parent reply other threads:[~2023-03-08 2:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-06 21:08 [PATCH net-next 0/8][pull request] i40e: support XDP multi-buffer Tony Nguyen
2023-03-06 21:08 ` [PATCH net-next 1/8] i40e: consolidate maximum frame size calculation for vsi Tony Nguyen
2023-03-06 21:08 ` [PATCH net-next 2/8] i40e: change Rx buffer size for legacy-rx to support XDP multi-buffer Tony Nguyen
2023-03-08 2:18 ` Jakub Kicinski [this message]
2023-03-08 12:22 ` Sarkar, Tirthendu
2023-03-09 2:28 ` Jakub Kicinski
2023-03-06 21:08 ` [PATCH net-next 3/8] i40e: add pre-xdp page_count in rx_buffer Tony Nguyen
2023-03-06 21:08 ` [PATCH net-next 4/8] i40e: Change size to truesize when using i40e_rx_buffer_flip() Tony Nguyen
2023-03-06 21:08 ` [PATCH net-next 5/8] i40e: use frame_sz instead of recalculating truesize for building skb Tony Nguyen
2023-03-06 21:08 ` [PATCH net-next 6/8] i40e: introduce next_to_process to i40e_ring Tony Nguyen
2023-03-06 21:08 ` [PATCH net-next 7/8] i40e: add xdp_buff to i40e_ring struct Tony Nguyen
2023-03-06 21:08 ` [PATCH net-next 8/8] i40e: add support for XDP multi-buffer Rx Tony Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230307181829.5dcec646@kernel.org \
--to=kuba@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=chandanx.rout@intel.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tirthendu.sarkar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).