From: Jakub Kicinski <kuba@kernel.org>
To: Shay Agroskin <shayagr@amazon.com>
Cc: David Miller <davem@davemloft.net>, <netdev@vger.kernel.org>,
"Woodhouse, David" <dwmw@amazon.com>,
"Machulsky, Zorik" <zorik@amazon.com>,
"Matushevsky, Alexander" <matua@amazon.com>,
Saeed Bshara <saeedb@amazon.com>, "Wilson, Matt" <msw@amazon.com>,
"Liguori, Anthony" <aliguori@amazon.com>,
"Bshara, Nafea" <nafea@amazon.com>,
"Belgazal, Netanel" <netanel@amazon.com>,
"Saidi, Ali" <alisaidi@amazon.com>,
"Herrenschmidt, Benjamin" <benh@amazon.com>,
"Kiyanovski, Arthur" <akiyano@amazon.com>,
"Dagan, Noam" <ndagan@amazon.com>,
"Arinzon, David" <darinzon@amazon.com>,
"Itzko, Shahar" <itzko@amazon.com>,
"Abboud, Osama" <osamaabb@amazon.com>
Subject: Re: [PATCH RFC v3 net-next 0/5] Add tx push buf len param to ethtool
Date: Wed, 8 Mar 2023 18:34:43 -0800 [thread overview]
Message-ID: <20230308183443.5284c51b@kernel.org> (raw)
In-Reply-To: <20230307102458.2756297-1-shayagr@amazon.com>
On Tue, 7 Mar 2023 12:24:53 +0200 Shay Agroskin wrote:
> Changed since v2:
> - Added a check that the driver advertises support for TX push buffer
> instead of defaulting the response to 0.
> - Moved cosmetic changes to their own commits
> - Removed usage of gotos which goes against Linux coding style
> - Make ENA driver reject an attempt to configure TX push buffer when
> it's not supported (no LLQ is used)
LGTM!
Feel free to add my:
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
On patch one, because checkpatch will complain otherwise.
And repost as non-RFC.
prev parent reply other threads:[~2023-03-09 2:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-07 10:24 [PATCH RFC v3 net-next 0/5] Add tx push buf len param to ethtool Shay Agroskin
2023-03-07 10:24 ` [PATCH RFC v3 net-next 1/5] ethtool: Add support for configuring tx_push_buf_len Shay Agroskin
2023-03-07 10:24 ` [PATCH RFC v3 net-next 2/5] net: ena: Make few cosmetic preparations to support large LLQ Shay Agroskin
2023-03-07 10:24 ` [PATCH RFC v3 net-next 3/5] net: ena: Add an option to configure large LLQ headers Shay Agroskin
2023-03-07 10:24 ` [PATCH RFC v3 net-next 4/5] net: ena: Recalculate TX state variables every device reset Shay Agroskin
2023-03-07 10:28 ` [PATCH RFC v3 net-next 5/5] net: ena: Add support to changing tx_push_buf_len Shay Agroskin
2023-03-09 2:34 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230308183443.5284c51b@kernel.org \
--to=kuba@kernel.org \
--cc=akiyano@amazon.com \
--cc=aliguori@amazon.com \
--cc=alisaidi@amazon.com \
--cc=benh@amazon.com \
--cc=darinzon@amazon.com \
--cc=davem@davemloft.net \
--cc=dwmw@amazon.com \
--cc=itzko@amazon.com \
--cc=matua@amazon.com \
--cc=msw@amazon.com \
--cc=nafea@amazon.com \
--cc=ndagan@amazon.com \
--cc=netanel@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=osamaabb@amazon.com \
--cc=saeedb@amazon.com \
--cc=shayagr@amazon.com \
--cc=zorik@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).