From: Rob Herring <robh@kernel.org>
To: Samin Guo <samin.guo@starfivetech.com>
Cc: linux-riscv@lists.infradead.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Emil Renner Berthing <kernel@esmil.dk>,
Richard Cochran <richardcochran@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Peter Geis <pgwipeout@gmail.com>,
Yanhong Wang <yanhong.wang@starfivetech.com>
Subject: Re: [PATCH v5 03/12] dt-bindings: net: snps,dwmac: Add an optional resets single 'ahb'
Date: Wed, 8 Mar 2023 15:57:09 -0600 [thread overview]
Message-ID: <20230308215709.GA3904341-robh@kernel.org> (raw)
In-Reply-To: <20230303085928.4535-4-samin.guo@starfivetech.com>
On Fri, Mar 03, 2023 at 04:59:19PM +0800, Samin Guo wrote:
> According to:
> stmmac_platform.c: stmmac_probe_config_dt
> stmmac_main.c: stmmac_dvr_probe
That's not really a reason on its own. Maybe the driver is wrong. Do we
know what hardware needs this?
> dwmac controller may require one (stmmaceth) or two (stmmaceth+ahb)
> reset signals, and the maxItems of resets/reset-names is going to be 2.
>
> Signed-off-by: Samin Guo <samin.guo@starfivetech.com>
> ---
> .../devicetree/bindings/net/snps,dwmac.yaml | 14 ++++++++++----
> 1 file changed, 10 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> index b4135d5297b4..89099a888f0b 100644
> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> @@ -133,12 +133,18 @@ properties:
> - ptp_ref
>
> resets:
> - maxItems: 1
> - description:
> - MAC Reset signal.
> + minItems: 1
> + items:
> + - description: GMAC stmmaceth reset
> + - description: AHB reset
>
> reset-names:
> - const: stmmaceth
> + minItems: 1
> + maxItems: 2
> + contains:
This means 'reset-names = "foo", "ahb";' is valid. You want 'items'
instead. However, that still allows the below string in any order. Do we
really need that? If not, then you want:
items:
- const: stmmaceth
- const: ahb
> + enum:
> + - stmmaceth
> + - ahb
>
> power-domains:
> maxItems: 1
> --
> 2.17.1
>
next prev parent reply other threads:[~2023-03-08 21:57 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-03 8:59 [PATCH v5 00/12] Add Ethernet driver for StarFive JH7110 SoC Samin Guo
2023-03-03 8:59 ` [PATCH v5 01/12] dt-bindings: net: snps,dwmac: Add dwmac-5.20 version Samin Guo
2023-03-03 8:59 ` [PATCH v5 02/12] net: stmmac: platform: Add snps,dwmac-5.20 IP compatible string Samin Guo
2023-03-03 8:59 ` [PATCH v5 03/12] dt-bindings: net: snps,dwmac: Add an optional resets single 'ahb' Samin Guo
2023-03-08 21:57 ` Rob Herring [this message]
2023-03-09 3:10 ` Guo Samin
2023-03-03 8:59 ` [PATCH v5 04/12] dt-bindings: net: Add support StarFive dwmac Samin Guo
2023-03-08 21:59 ` Rob Herring
2023-03-09 1:26 ` Guo Samin
2023-03-03 8:59 ` [PATCH v5 05/12] riscv: dts: starfive: jh7110: Add ethernet device nodes Samin Guo
2023-03-03 13:45 ` Andrew Lunn
2023-03-06 2:19 ` Guo Samin
2023-03-04 22:57 ` Emil Renner Berthing
2023-03-07 7:50 ` Guo Samin
2023-03-03 8:59 ` [PATCH v5 06/12] net: stmmac: Add glue layer for StarFive JH7110 SoC Samin Guo
2023-03-03 16:18 ` Emil Renner Berthing
2023-03-06 7:15 ` Guo Samin
2023-03-06 12:21 ` Emil Renner Berthing
2023-03-07 7:57 ` Guo Samin
2023-03-10 0:02 ` Emil Renner Berthing
2023-03-10 0:39 ` Emil Renner Berthing
2023-03-10 1:55 ` Guo Samin
2023-03-10 9:03 ` Emil Renner Berthing
2023-03-10 11:13 ` Guo Samin
2023-03-03 8:59 ` [PATCH v5 07/12] dt-bindings: net: starfive,jh7110-dwmac: Add starfive,syscon Samin Guo
2023-03-08 22:03 ` Rob Herring
2023-03-09 1:16 ` Guo Samin
2023-03-03 8:59 ` [PATCH v5 08/12] net: stmmac: starfive_dmac: Add phy interface settings Samin Guo
2023-03-03 13:36 ` Andrew Lunn
2023-03-03 16:50 ` Emil Renner Berthing
2023-03-06 3:06 ` Guo Samin
2023-03-06 12:49 ` Emil Renner Berthing
2023-03-06 13:06 ` Andrew Lunn
2023-03-07 1:50 ` Guo Samin
2023-03-07 2:16 ` Guo Samin
2023-03-03 8:59 ` [PATCH v5 09/12] riscv: dts: starfive: jh7110: Add syscon to support " Samin Guo
2023-03-03 8:59 ` [PATCH v5 10/12] riscv: dts: starfive: visionfive-2-v1.3b: Add gmac+phy's delay configuration Samin Guo
2023-03-03 8:59 ` [PATCH v5 11/12] riscv: dts: starfive: visionfive-2-v1.2a: " Samin Guo
2023-03-06 13:00 ` Emil Renner Berthing
2023-03-07 1:43 ` Guo Samin
2023-03-07 12:40 ` Emil Renner Berthing
2023-03-08 3:01 ` Guo Samin
2023-03-03 8:59 ` [PATCH v5 12/12] riscv: dts: starfive: visionfive 2: Enable gmac device tree node Samin Guo
2023-03-06 13:04 ` Emil Renner Berthing
2023-03-07 1:21 ` Guo Samin
2023-03-07 12:23 ` Emil Renner Berthing
2023-03-10 8:09 ` [PATCH v5 00/12] Add Ethernet driver for StarFive JH7110 SoC Tommaso Merciai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230308215709.GA3904341-robh@kernel.org \
--to=robh@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kernel@esmil.dk \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pgwipeout@gmail.com \
--cc=richardcochran@gmail.com \
--cc=samin.guo@starfivetech.com \
--cc=yanhong.wang@starfivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).