From: Ronak Doshi <doshir@vmware.com>
To: <netdev@vger.kernel.org>
Cc: Ronak Doshi <doshir@vmware.com>, <stable@vger.kernel.org>,
VMware PV-Drivers Reviewers <pv-drivers@vmware.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Guolin Yang <gyang@vmware.com>,
open list <linux-kernel@vger.kernel.org>
Subject: [PATCH net] vmxnet3: use gro callback when UPT is enabled
Date: Wed, 8 Mar 2023 14:25:03 -0800 [thread overview]
Message-ID: <20230308222504.25675-1-doshir@vmware.com> (raw)
Currently, vmxnet3 uses GRO callback only if LRO is disabled. However,
on smartNic based setups where UPT is supported, LRO can be enabled
from guest VM but UPT devicve does not support LRO as of now. In such
cases, there can be performance degradation as GRO is not being done.
This patch fixes this issue by calling GRO API when UPT is enabled. We
use updateRxProd to determine if UPT mode is active or not.
Cc: stable@vger.kernel.org
Fixes: 6f91f4ba046e ("vmxnet3: add support for capability registers")
Signed-off-by: Ronak Doshi <doshir@vmware.com>
Acked-by: Guolin Yang <gyang@vmware.com>
---
drivers/net/vmxnet3/vmxnet3_drv.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c
index 682987040ea8..8f7ac7d85afc 100644
--- a/drivers/net/vmxnet3/vmxnet3_drv.c
+++ b/drivers/net/vmxnet3/vmxnet3_drv.c
@@ -1688,7 +1688,8 @@ vmxnet3_rq_rx_complete(struct vmxnet3_rx_queue *rq,
if (unlikely(rcd->ts))
__vlan_hwaccel_put_tag(skb, htons(ETH_P_8021Q), rcd->tci);
- if (adapter->netdev->features & NETIF_F_LRO)
+ /* Use GRO callback if UPT is enabled */
+ if ((adapter->netdev->features & NETIF_F_LRO) && !rq->shared->updateRxProd)
netif_receive_skb(skb);
else
napi_gro_receive(&rq->napi, skb);
--
2.11.0
next reply other threads:[~2023-03-08 22:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-08 22:25 Ronak Doshi [this message]
2023-03-09 0:34 ` [PATCH net] vmxnet3: use gro callback when UPT is enabled Yunsheng Lin
2023-03-09 22:50 ` Ronak Doshi
2023-03-10 1:02 ` Yunsheng Lin
2023-03-14 21:09 ` Ronak Doshi
2023-03-15 1:51 ` Yunsheng Lin
2023-03-15 2:27 ` Ronak Doshi
2023-03-15 3:04 ` Yunsheng Lin
2023-03-15 23:44 ` Ronak Doshi
2023-03-16 1:47 ` Yunsheng Lin
2023-03-16 4:03 ` Ronak Doshi
2023-03-16 4:13 ` Jakub Kicinski
2023-03-16 5:21 ` Ronak Doshi
2023-03-16 20:34 ` Jakub Kicinski
2023-03-17 2:37 ` Yunsheng Lin
2023-03-17 20:27 ` Ronak Doshi
2023-03-18 2:43 ` Jakub Kicinski
-- strict thread matches above, loose matches on Subject: below --
2023-03-23 5:43 Ronak Doshi
2023-03-23 15:48 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230308222504.25675-1-doshir@vmware.com \
--to=doshir@vmware.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gyang@vmware.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pv-drivers@vmware.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).