From: Vladimir Oltean <olteanv@gmail.com>
To: Qingtao Cao <qingtao.cao.au@gmail.com>
Cc: andrew@lunn.ch, vivien.didelot@gmail.com, f.fainelli@gmail.com,
netdev <netdev@vger.kernel.org>
Subject: Re: Question: DSA on Marvell 6390R switch dropping EAPOL packets with unicast MAC DA
Date: Thu, 9 Mar 2023 16:21:03 +0200 [thread overview]
Message-ID: <20230309142103.dg4qfksz4k2itotd@skbuf> (raw)
In-Reply-To: <20230309131601.wxfsfo2dbfyj3ybe@skbuf>
On Thu, Mar 09, 2023 at 03:16:01PM +0200, Vladimir Oltean wrote:
> Speaking of bridging, is the net2p9 interface under any bridge during
> your testing, or does it operate as a standalone interface? If it's
> under a bridge, could you repeat the experiment with it as standalone?
Ah, I shouldn't have asked this, because the information you've provided:
> > if (trunk)
> > skb->offload_fwd_mark = true;
> > else if (!trap)
> > dsa_default_offload_fwd_mark(skb);
> >
> > will set skb->offload_fwd_mark = 1.
is enough for me to determine that yes, net2p9 *is* under a bridge.
This is because of the implementation:
static inline void dsa_default_offload_fwd_mark(struct sk_buff *skb)
{
struct dsa_port *dp = dsa_slave_to_port(skb->dev);
skb->offload_fwd_mark = !!(dp->bridge);
}
if it wasn't under a bridge, then skb->offload_fwd_mark would have never
been 1.
Ok, so having this said, now I have a pretty strong suspicion as to what
the issue is.
The RX handler of the software bridge layer - br_handle_frame() - steals
packets from the bridge port interface (net2p9) before those packets
ever reach the PF_PACKET socket opened by wpa_supplicant. "Steals" means
"returns RX_HANDLER_CONSUMED and not RX_HANDLER_PASS".
There is a netfilter hook through which you can tell the bridge
"hey, don't steal this kind of traffic, leave it on the bridge port!"
The command, applied to EAPOL, would look something like this:
/sbin/ebtables --table broute --append BROUTING --protocol 0x888e --jump DROP
Would you mind giving this a try (and do the rest of the debugging later)?
next prev parent reply other threads:[~2023-03-09 14:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAPcThSFCN7mKP2_ZhqJi9-nGNTYmV5uB23aToAudodZDEnunoA@mail.gmail.com>
2023-03-09 11:06 ` Question: DSA on Marvell 6390R switch dropping EAPOL packets with unicast MAC DA Vladimir Oltean
[not found] ` <CAPcThSH0Lp7ZNp4rhce3tFCjqPUZSuuySBFwv4sVvHKHFmy77Q@mail.gmail.com>
[not found] ` <20230309131601.wxfsfo2dbfyj3ybe@skbuf>
2023-03-09 14:21 ` Vladimir Oltean [this message]
[not found] ` <CAPcThSECEBMN0X869GhBWnTpePKRx_SPCZTv66VrPNaWpHmCxg@mail.gmail.com>
2023-03-10 9:12 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230309142103.dg4qfksz4k2itotd@skbuf \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=qingtao.cao.au@gmail.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox