From: Francois Romieu <romieu@fr.zoreil.com>
To: Gencen Gan <u202011061@gmail.com>
Cc: Chas Williams <3chas3@gmail.com>,
Dongliang Mu <dzm91@hust.edu.cn>,
linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] atm: he: fix potential ioremap leak of membase in he_dev
Date: Fri, 10 Mar 2023 12:28:50 +0100 [thread overview]
Message-ID: <20230310112850.GA424646@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <20230310102256.1130846-1-u202011061@gmail.com>
Gencen Gan <u202011061@gmail.com> :
> In the function he_start() in drivers/atm/he.c, there
> is no unmapping of he_dev->membase in the branch that
> exits due to an error like reset failure, which may
> cause a memory leak.
Why would he_dev->membase not be unmapped in he_stop() ?
he_stop() is paired with he_start() as soon a he_start() returns
anything different from 0 in he_init_one(). I see no other place
where he_start() is used.
The atm_dev/he_dev pointers also seem correctly set.
--
Ueimor
next prev parent reply other threads:[~2023-03-10 11:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 10:22 [PATCH] atm: he: fix potential ioremap leak of membase in he_dev Gencen Gan
2023-03-10 11:28 ` Francois Romieu [this message]
2023-03-10 13:15 ` Dongliang Mu
2023-03-10 15:12 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230310112850.GA424646@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=3chas3@gmail.com \
--cc=dzm91@hust.edu.cn \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=u202011061@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox