From: Sumitra Sharma <sumitraartsy@gmail.com>
To: outreachy@lists.linux.dev, manishc@marvell.com,
GR-Linux-NIC-Dev@marvell.com, coiby.xu@gmail.com,
gregkh@linuxfoundation.org, netdev@vger.kernel.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Cc: outreachy@lists.linux.dev
Subject: [PATCH] Staging: qlge: Remove parenthesis around single condition
Date: Sat, 11 Mar 2023 06:04:09 -0800 [thread overview]
Message-ID: <20230311140409.GA22831@ubuntu> (raw)
At line #354 checkpatch.pl:
CHECK: Unnecessary parentheses around 'i == 0x00000114'
CHECK: Unnecessary parentheses around 'i == 0x00000118'
CHECK: Unnecessary parenthesis around 'i == 0x00000140'
CHECK: Unnecessary parentheses around 'i == 0x0000013c'
Signed-off-by: Sumitra Sharma <sumitraartsy@gmail.com>
---
drivers/staging/qlge/qlge_dbg.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge/qlge_dbg.c
index 66d28358342f..b190a2993033 100644
--- a/drivers/staging/qlge/qlge_dbg.c
+++ b/drivers/staging/qlge/qlge_dbg.c
@@ -351,10 +351,10 @@ static int qlge_get_xgmac_regs(struct qlge_adapter *qdev, u32 *buf,
/* We're reading 400 xgmac registers, but we filter out
* several locations that are non-responsive to reads.
*/
- if ((i == 0x00000114) ||
- (i == 0x00000118) ||
- (i == 0x0000013c) ||
- (i == 0x00000140) ||
+ if (i == 0x00000114 ||
+ i == 0x00000118 ||
+ i == 0x0000013c ||
+ i == 0x00000140 ||
(i > 0x00000150 && i < 0x000001fc) ||
(i > 0x00000278 && i < 0x000002a0) ||
(i > 0x000002c0 && i < 0x000002cf) ||
--
2.25.1
next reply other threads:[~2023-03-11 14:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-11 14:04 Sumitra Sharma [this message]
2023-03-11 14:09 ` [PATCH] Staging: qlge: Remove parenthesis around single condition Dan Carpenter
2023-03-11 14:43 ` Sumitra Sharma
2023-03-11 14:49 ` Julia Lawall
2023-03-11 14:59 ` Dan Carpenter
2023-03-11 20:35 ` Fabio M. De Francesco
2023-03-12 7:17 ` Sumitra Sharma
2023-03-12 10:39 ` Fabio M. De Francesco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230311140409.GA22831@ubuntu \
--to=sumitraartsy@gmail.com \
--cc=GR-Linux-NIC-Dev@marvell.com \
--cc=coiby.xu@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=manishc@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).