* [PATCH v2] Staging: qlge: Fix indentation in conditional statement
@ 2023-03-11 17:25 Sumitra Sharma
2023-03-13 4:07 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Sumitra Sharma @ 2023-03-11 17:25 UTC (permalink / raw)
To: outreachy, GR-Linux-NIC-Dev, coiby.xu, gregkh, linux-kernel,
linux-staging, manishc, netdev, error27
Cc: outreachy
Add tabs/spaces in conditional statements in qlge_dbg.c to fix the
indentation.
Signed-off-by: Sumitra Sharma <sumitraartsy@gmail.com>
---
v2: Fix indentation in conditional statement, noted by Dan Carpenter
<error27@gmail.com>
drivers/staging/qlge/qlge_dbg.c | 35 +++++++++++++++------------------
1 file changed, 16 insertions(+), 19 deletions(-)
diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge/qlge_dbg.c
index b190a2993033..c7e865f515cf 100644
--- a/drivers/staging/qlge/qlge_dbg.c
+++ b/drivers/staging/qlge/qlge_dbg.c
@@ -351,26 +351,23 @@ static int qlge_get_xgmac_regs(struct qlge_adapter *qdev, u32 *buf,
/* We're reading 400 xgmac registers, but we filter out
* several locations that are non-responsive to reads.
*/
- if (i == 0x00000114 ||
- i == 0x00000118 ||
- i == 0x0000013c ||
- i == 0x00000140 ||
- (i > 0x00000150 && i < 0x000001fc) ||
- (i > 0x00000278 && i < 0x000002a0) ||
- (i > 0x000002c0 && i < 0x000002cf) ||
- (i > 0x000002dc && i < 0x000002f0) ||
- (i > 0x000003c8 && i < 0x00000400) ||
- (i > 0x00000400 && i < 0x00000410) ||
- (i > 0x00000410 && i < 0x00000420) ||
- (i > 0x00000420 && i < 0x00000430) ||
- (i > 0x00000430 && i < 0x00000440) ||
- (i > 0x00000440 && i < 0x00000450) ||
- (i > 0x00000450 && i < 0x00000500) ||
- (i > 0x0000054c && i < 0x00000568) ||
- (i > 0x000005c8 && i < 0x00000600)) {
+ if ((i == 0x00000114) || (i == 0x00000118) ||
+ (i == 0x0000013c) || (i == 0x00000140) ||
+ (i > 0x00000150 && i < 0x000001fc) ||
+ (i > 0x00000278 && i < 0x000002a0) ||
+ (i > 0x000002c0 && i < 0x000002cf) ||
+ (i > 0x000002dc && i < 0x000002f0) ||
+ (i > 0x000003c8 && i < 0x00000400) ||
+ (i > 0x00000400 && i < 0x00000410) ||
+ (i > 0x00000410 && i < 0x00000420) ||
+ (i > 0x00000420 && i < 0x00000430) ||
+ (i > 0x00000430 && i < 0x00000440) ||
+ (i > 0x00000440 && i < 0x00000450) ||
+ (i > 0x00000450 && i < 0x00000500) ||
+ (i > 0x0000054c && i < 0x00000568) ||
+ (i > 0x000005c8 && i < 0x00000600)) {
if (other_function)
- status =
- qlge_read_other_func_xgmac_reg(qdev, i, buf);
+ status = qlge_read_other_func_xgmac_reg(qdev, i, buf);
else
status = qlge_read_xgmac_reg(qdev, i, buf);
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] Staging: qlge: Fix indentation in conditional statement
2023-03-11 17:25 [PATCH v2] Staging: qlge: Fix indentation in conditional statement Sumitra Sharma
@ 2023-03-13 4:07 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2023-03-13 4:07 UTC (permalink / raw)
To: Sumitra Sharma
Cc: outreachy, GR-Linux-NIC-Dev, coiby.xu, gregkh, linux-kernel,
linux-staging, manishc, netdev
On Sat, Mar 11, 2023 at 09:25:40AM -0800, Sumitra Sharma wrote:
> Add tabs/spaces in conditional statements in qlge_dbg.c to fix the
> indentation.
>
> Signed-off-by: Sumitra Sharma <sumitraartsy@gmail.com>
> ---
> v2: Fix indentation in conditional statement, noted by Dan Carpenter
> <error27@gmail.com>
>
This doesn't apply. You need to start from a fresh git tree. Please
read my whole earlier email again.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-13 4:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-11 17:25 [PATCH v2] Staging: qlge: Fix indentation in conditional statement Sumitra Sharma
2023-03-13 4:07 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).