From: Sean Anderson <seanga2@gmail.com>
To: "David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Simon Horman <simon.horman@corigine.com>,
Sean Anderson <seanga2@gmail.com>
Subject: [PATCH net-next v2 8/9] net: sunhme: Inline error returns
Date: Sat, 11 Mar 2023 13:19:04 -0500 [thread overview]
Message-ID: <20230311181905.3593904-9-seanga2@gmail.com> (raw)
In-Reply-To: <20230311181905.3593904-1-seanga2@gmail.com>
The err_out label used to have cleanup. Now that it just returns, inline it
everywhere.
Signed-off-by: Sean Anderson <seanga2@gmail.com>
---
Changes in v2:
- New
drivers/net/ethernet/sun/sunhme.c | 19 ++++++-------------
1 file changed, 6 insertions(+), 13 deletions(-)
diff --git a/drivers/net/ethernet/sun/sunhme.c b/drivers/net/ethernet/sun/sunhme.c
index 41b2f941c607..0b903ece624a 100644
--- a/drivers/net/ethernet/sun/sunhme.c
+++ b/drivers/net/ethernet/sun/sunhme.c
@@ -2622,30 +2622,25 @@ static int happy_meal_pci_probe(struct pci_dev *pdev,
err = pcim_enable_device(pdev);
if (err)
- goto err_out;
+ return err;
pci_set_master(pdev);
if (!strcmp(prom_name, "SUNW,qfe") || !strcmp(prom_name, "qfe")) {
qp = quattro_pci_find(pdev);
- if (IS_ERR(qp)) {
- err = PTR_ERR(qp);
- goto err_out;
- }
+ if (IS_ERR(qp))
+ return PTR_ERR(qp);
for (qfe_slot = 0; qfe_slot < 4; qfe_slot++)
if (!qp->happy_meals[qfe_slot])
goto found_slot;
- err = -ENODEV;
- goto err_out;
+ return -ENODEV;
}
found_slot:
dev = devm_alloc_etherdev(&pdev->dev, sizeof(struct happy_meal));
- if (!dev) {
- err = -ENOMEM;
- goto err_out;
- }
+ if (!dev)
+ return -ENOMEM;
SET_NETDEV_DEV(dev, &pdev->dev);
hp = netdev_priv(dev);
@@ -2793,8 +2788,6 @@ static int happy_meal_pci_probe(struct pci_dev *pdev,
err_out_clear_quattro:
if (qp != NULL)
qp->happy_meals[qfe_slot] = NULL;
-
-err_out:
return err;
}
--
2.37.1
next prev parent reply other threads:[~2023-03-11 18:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-11 18:18 [PATCH net-next v2 0/9] net: sunhme: Probe/IRQ cleanups Sean Anderson
2023-03-11 18:18 ` [PATCH net-next v2 1/9] net: sunhme: Just restart autonegotiation if we can't bring the link up Sean Anderson
2023-03-11 18:18 ` [PATCH net-next v2 2/9] net: sunhme: Remove residual polling code Sean Anderson
2023-03-11 18:18 ` [PATCH net-next v2 3/9] net: sunhme: Unify IRQ requesting Sean Anderson
2023-03-11 18:19 ` [PATCH net-next v2 4/9] net: sunhme: Alphabetize includes Sean Anderson
2023-03-11 18:19 ` [PATCH net-next v2 5/9] net: sunhme: Switch SBUS to devres Sean Anderson
2023-03-11 18:19 ` [PATCH net-next v2 6/9] net: sunhme: Consolidate mac address initialization Sean Anderson
2023-03-11 18:19 ` [PATCH net-next v2 7/9] net: sunhme: Clean up mac address init Sean Anderson
2023-03-11 18:19 ` Sean Anderson [this message]
2023-03-11 18:19 ` [PATCH net-next v2 9/9] net: sunhme: Consolidate common probe tasks Sean Anderson
2023-03-14 0:27 ` [PATCH net-next v2 0/9] net: sunhme: Probe/IRQ cleanups Jakub Kicinski
2023-03-14 0:36 ` Sean Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230311181905.3593904-9-seanga2@gmail.com \
--to=seanga2@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=simon.horman@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).