From: Jakub Kicinski <kuba@kernel.org>
To: David Laight <David.Laight@ACULAB.COM>
Cc: 'Horatiu Vultur' <horatiu.vultur@microchip.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"richardcochran@gmail.com" <richardcochran@gmail.com>,
"UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>
Subject: Re: [PATCH net-next 2/2] net: lan966x: Stop using packing library
Date: Mon, 13 Mar 2023 15:18:44 -0700 [thread overview]
Message-ID: <20230313151844.6eee28c6@kernel.org> (raw)
In-Reply-To: <cad1c4aac9ae4047b8ed29b181c908fd@AcuMS.aculab.com>
On Mon, 13 Mar 2023 17:04:11 +0000 David Laight wrote:
> It has to be possible to do much better that that.
> Given that 'pos' and 'length' are always constants it looks like
> each call should reduce to (something like):
> ifh[k] |= val << n;
> ifk[k + 1] |= val >> (8 - n);
> ...
> It might be that the compiler manages to do this, but I doubt it.
Agreed, going bit-by-bit seems overly cautious.
next prev parent reply other threads:[~2023-03-13 22:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-12 20:24 [PATCH net-next 0/2] net: lan966x: Improve TX/RX of frames from/to CPU Horatiu Vultur
2023-03-12 20:24 ` [PATCH net-next 1/2] net: lan966x: Don't read RX timestamp if not needed Horatiu Vultur
2023-03-12 20:24 ` [PATCH net-next 2/2] net: lan966x: Stop using packing library Horatiu Vultur
2023-03-13 17:04 ` David Laight
2023-03-13 22:18 ` Jakub Kicinski [this message]
2023-03-15 13:33 ` 'Horatiu Vultur'
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230313151844.6eee28c6@kernel.org \
--to=kuba@kernel.org \
--cc=David.Laight@ACULAB.COM \
--cc=UNGLinuxDriver@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horatiu.vultur@microchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).