From: Jakub Kicinski <kuba@kernel.org>
To: Zheng Wang <zyytlz.wz@163.com>
Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
hackerzheng666@gmail.com, 1395428693sheep@gmail.com,
alex000young@gmail.com
Subject: Re: [PATCH net] net: ethernet: fix use after free bug in ns83820_remove_one due to race condition
Date: Mon, 13 Mar 2023 16:26:30 -0700 [thread overview]
Message-ID: <20230313162630.225f6a86@kernel.org> (raw)
In-Reply-To: <20230309094231.3808770-1-zyytlz.wz@163.com>
On Thu, 9 Mar 2023 17:42:31 +0800 Zheng Wang wrote:
> + cancel_work_sync(&dev->tq_refill);
> ns83820_disable_interrupts(dev); /* paranoia */
>
> unregister_netdev(ndev);
Canceling the work before unregister can't work.
Please take a closer look, the work to refill a ring should be
canceled when the ring itself is dismantled.
next prev parent reply other threads:[~2023-03-13 23:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 9:42 [PATCH net] net: ethernet: fix use after free bug in ns83820_remove_one due to race condition Zheng Wang
2023-03-13 23:26 ` Jakub Kicinski [this message]
2023-03-14 1:59 ` Zheng Hacker
2023-03-15 4:10 ` Jakub Kicinski
2023-03-15 8:58 ` Zheng Hacker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230313162630.225f6a86@kernel.org \
--to=kuba@kernel.org \
--cc=1395428693sheep@gmail.com \
--cc=alex000young@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hackerzheng666@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=zyytlz.wz@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).