From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87106C74A5B for ; Tue, 14 Mar 2023 13:45:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231231AbjCNNpY (ORCPT ); Tue, 14 Mar 2023 09:45:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33624 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232593AbjCNNpE (ORCPT ); Tue, 14 Mar 2023 09:45:04 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 947DEB06FF for ; Tue, 14 Mar 2023 06:42:00 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D61E2B81981 for ; Tue, 14 Mar 2023 13:41:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8413FC433EF; Tue, 14 Mar 2023 13:41:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678801303; bh=frVH5IoL6TyN/bNQeAfRiAcHPIkUJee+isIHpwYi7PA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LN8DfIC2EspZ1pVhPpWkpuf2d2qq3/y8oqDvJsgIjTNqPsQOXeHSQvB7TiX3867cb YyqUi5r8mhR2u3pxVEjEZtPAkiTn+8U8/tqIqnzGd6cQU9KKaD0rVGwx2k/mxZPRH0 cNzBbChSUkd3ozbsYS+zhP+NEMus3hrXUpVwVUNG6/F9zzgMCeano2yqmHsddRCvrL 1Xs7IK7YxIHO4A7Ic+hVr5IBKVFjskdo2+zupVebd4IEl00iPF9uyiSx03uk9LmgMX hAmw4XOya+FVXPQBHi8WQCogLakrxsw4m7Z2C2IiNK1DCk/JD2sLzQL5qSb2hrWXxG Rm7p6S2XSSHaw== Date: Tue, 14 Mar 2023 15:41:38 +0200 From: Leon Romanovsky To: Tony Nguyen Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, edumazet@google.com, netdev@vger.kernel.org, Jacob Keller , Michal Swiatkowski , Marek Szlosek Subject: Re: [PATCH net-next 01/14] ice: re-order ice_mbx_reset_snapshot function Message-ID: <20230314134138.GF36557@unreal> References: <20230313182123.483057-1-anthony.l.nguyen@intel.com> <20230313182123.483057-2-anthony.l.nguyen@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230313182123.483057-2-anthony.l.nguyen@intel.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Mar 13, 2023 at 11:21:10AM -0700, Tony Nguyen wrote: > From: Jacob Keller > > A future change is going to refactor the VF mailbox overflow detection > logic, including modifying ice_mbx_reset_snapshot and its callers. To make > this change easier to review, first move the ice_mbx_reset_snapshot > function higher in the ice_vf_mbx.c file. > > Signed-off-by: Jacob Keller > Reviewed-by: Michal Swiatkowski > Tested-by: Marek Szlosek > Signed-off-by: Tony Nguyen > --- > drivers/net/ethernet/intel/ice/ice_vf_mbx.c | 48 ++++++++++----------- > 1 file changed, 24 insertions(+), 24 deletions(-) > Thanks, Reviewed-by: Leon Romanovsky