From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DBA6C76195 for ; Tue, 14 Mar 2023 17:50:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230179AbjCNRt7 (ORCPT ); Tue, 14 Mar 2023 13:49:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50000 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230159AbjCNRtz (ORCPT ); Tue, 14 Mar 2023 13:49:55 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5919DA0299 for ; Tue, 14 Mar 2023 10:49:51 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 12FBCB81AB7 for ; Tue, 14 Mar 2023 17:49:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BFAEDC4339C; Tue, 14 Mar 2023 17:49:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678816188; bh=mdETvqf2oL9oH+IfFZXIEosb/DcnJaIJ/GXWT2owDYU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ARQNcZ397f3dTue3UYTLLA2q4zvOaFDrcWiRXVIY8HbrezEcWm5fo7ZQpMAmG4NAT hkdDCPMkGdWjo3D3MWQbLELoHm8B52UcmROjPVCmRdx2TIzdaVwBPygGyPdCMTgwFd rYyNFwjpam761xtP4+Ek6CPT+Jql7iZe1Gy+UxvrH4+9n9xSgIlhbfC/YCtktCciuH uZhZTJlfGN9XEJ0+X2GmxGQEwFFia3+aFrGhZmGBuYs4sq79SazZc0/OYRiLGTmmrB 8Q3YPKou7VPVZrxixzElEVUgtpuIKFVkWDaVrqKYwv/RiVbSH+JmyPnstekDVwDYWf HEqm5owOsBw7A== From: Saeed Mahameed To: "David S. Miller" , Jakub Kicinski , Paolo Abeni , Eric Dumazet Cc: Saeed Mahameed , netdev@vger.kernel.org, Tariq Toukan , Emeel Hakim , Leon Romanovsky Subject: [net 01/14] net/mlx5e: Fix macsec ASO context alignment Date: Tue, 14 Mar 2023 10:49:27 -0700 Message-Id: <20230314174940.62221-2-saeed@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230314174940.62221-1-saeed@kernel.org> References: <20230314174940.62221-1-saeed@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Emeel Hakim Currently mlx5e_macsec_umr struct does not satisfy hardware memory alignment requirement. Hence the result of querying advanced steering operation (ASO) is not copied to the memory region as expected. Fix by satisfying hardware memory alignment requirement and move context to be first field in struct for better readability. Fixes: 1f53da676439 ("net/mlx5e: Create advanced steering operation (ASO) object for MACsec") Signed-off-by: Emeel Hakim Reviewed-by: Leon Romanovsky Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c index 08d0929e8260..8af53178e40d 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c @@ -89,8 +89,8 @@ struct mlx5e_macsec_rx_sc { }; struct mlx5e_macsec_umr { + u8 __aligned(64) ctx[MLX5_ST_SZ_BYTES(macsec_aso)]; dma_addr_t dma_addr; - u8 ctx[MLX5_ST_SZ_BYTES(macsec_aso)]; u32 mkey; }; -- 2.39.2