From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5B57C05027 for ; Tue, 14 Mar 2023 17:50:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229866AbjCNRuL (ORCPT ); Tue, 14 Mar 2023 13:50:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50268 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230426AbjCNRt6 (ORCPT ); Tue, 14 Mar 2023 13:49:58 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6885EA7287 for ; Tue, 14 Mar 2023 10:49:56 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 464E4CE1695 for ; Tue, 14 Mar 2023 17:49:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 67946C4339B; Tue, 14 Mar 2023 17:49:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678816192; bh=OhCG+HoqPYpf382jXR9O8a+Pon3qXkWhaZMmPLQLyOc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=p2HBHGeVHY12BWs2Gh6CgImXKFMTaKXHDYK0TFvbCPZkvidwniHo9tSO52c2igKzC dQeN3R2LQxDtQ1NPMb2TBRonD+M6fbkXXI+tyocwlqxubIptp9pB1M8QOX8WKzZbki q20A1UanJBz/kycyIx4/Q/Q3dR8dJ33e5TTSAT0pVHjf1SAdSL+m+kh+5T7pYroqIE 4CRkszD06z1UbOXFvicP0sBhPw7gfVCUvJM+zKrjNgUwPl9Vms0Ynzw4W0TZCIRnMx Dlp7Bl7+6QkqAApAXHzvtafX6OEBvu0mUc/j388rRxuFGT1KtzF2faP0JJ4/J4/Gfg SBW7BOxXRenvw== From: Saeed Mahameed To: "David S. Miller" , Jakub Kicinski , Paolo Abeni , Eric Dumazet Cc: Saeed Mahameed , netdev@vger.kernel.org, Tariq Toukan , Maor Dickman , Roi Dayan Subject: [net 06/14] net/mlx5: E-switch, Fix missing set of split_count when forward to ovs internal port Date: Tue, 14 Mar 2023 10:49:32 -0700 Message-Id: <20230314174940.62221-7-saeed@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230314174940.62221-1-saeed@kernel.org> References: <20230314174940.62221-1-saeed@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Maor Dickman Rules with mirror actions are split to two FTEs when the actions after the mirror action contains pedit, vlan push/pop or ct. Forward to ovs internal port adds implicit header rewrite (pedit) but missing trigger to do split. Fix by setting split_count when forwarding to ovs internal port which will trigger split in mirror rules. Fixes: 27484f7170ed ("net/mlx5e: Offload tc rules that redirect to ovs internal port") Signed-off-by: Maor Dickman Reviewed-by: Roi Dayan Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c index 70b8d2dfa751..90944bf271ce 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c @@ -4304,6 +4304,7 @@ int mlx5e_set_fwd_to_int_port_actions(struct mlx5e_priv *priv, esw_attr->dest_int_port = dest_int_port; esw_attr->dests[out_index].flags |= MLX5_ESW_DEST_CHAIN_WITH_SRC_PORT_CHANGE; + esw_attr->split_count = out_index; /* Forward to root fdb for matching against the new source vport */ attr->dest_chain = 0; -- 2.39.2