From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E33CC61DA4 for ; Wed, 15 Mar 2023 04:37:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230508AbjCOEhy (ORCPT ); Wed, 15 Mar 2023 00:37:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229705AbjCOEhw (ORCPT ); Wed, 15 Mar 2023 00:37:52 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A84C59E63 for ; Tue, 14 Mar 2023 21:37:51 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 33FA661AC9 for ; Wed, 15 Mar 2023 04:37:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 332ABC433EF; Wed, 15 Mar 2023 04:37:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678855070; bh=PbDrCEESpZPbr3O7600U95r39pZKHGXnaW/Ysy45g5U=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=UcdPBCx1fMWb367cWKC1vO2SKTcGajgFTLQSqsTzrZ0oyyd5XN35it0ZLkSQZXEPF ZpjFWfgkthnEd7rYdca7Ty+NT/gW4fCRsGweJ5CrKB8c962BRz4vXEmktyrWUmSbAb ibuur1V3QxX5MMhEz0ORqJ7SRpKdKBi3et6JqFS6ykgqwJjWJ1DvLPMtYVnQJLN/h+ 7XDhhloKtPQuFn3J8F6piQwdN1CSWDkLli4Ig3Egp/wY/9jnnm6Z2EXHeGuR7zpPh4 NFZvKtCTpRs6V5BjTOI7yu3VEygoPqSBAqJ5LQZjozpqlrtVd0AOUQnxC7UMvM6gwv Ygp2GtXEenQGA== Date: Tue, 14 Mar 2023 21:37:49 -0700 From: Jakub Kicinski To: Ido Schimmel Cc: Petr Machata , "David S. Miller" , Eric Dumazet , Paolo Abeni , netdev@vger.kernel.org, David Ahern , Shuah Khan , mlxsw@nvidia.com, Jacques de Laval Subject: Re: [PATCH net-next 0/5] net: Extend address label support Message-ID: <20230314213749.59b2aa43@kernel.org> In-Reply-To: References: <20230310171257.0127e74c@kernel.org> <87sfe8sniw.fsf@nvidia.com> <20230313151028.78fdfec6@kernel.org> <87a60fs2kp.fsf@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 14 Mar 2023 19:43:06 +0200 Ido Schimmel wrote: > On Tue, Mar 14, 2023 at 10:44:00AM +0100, Petr Machata wrote: > > Like with the labels, address replacement messages with an explicit > > IFA_PROTO are not bounced, they just neglect to actually change the > > protocol. But it makes no sense to me that someone would issue address > > replacement with an explicit proto set which differs from the current > > one, but would still rely on the fact that the proto doesn't change... > > Especially when replace does work with IPv6 addresses. Couple that with > the fact that it's a much newer attribute than the labels (added in > 5.18) and that it has no support in iproute2, FRR, libnl etc, the > chances of such a change breaking anyone are slim to none... Let's add Jacques, in case he knows something we don't know. Yes, that sounds fairly safe, we can risk it. Then again we may be putting different pieces of state into one field? There are holes next to ifa_proto in most (all?) structures. It wouldn't cost us too much to add a field for your exact use case, it seems. But no strong feelings, ifa_proto > 3 is a free-for-all, anyway.