From: Jakub Kicinski <kuba@kernel.org>
To: Anjali Kulkarni <anjali.k.kulkarni@oracle.com>
Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
zbr@ioremap.net, brauner@kernel.org, johannes@sipsolutions.net,
ecree.xilinx@gmail.com, leon@kernel.org, keescook@chromium.org,
socketcan@hartkopp.net, petrm@nvidia.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v2 2/5] connector/cn_proc: Add filtering to fix some bugs
Date: Tue, 14 Mar 2023 22:16:33 -0700 [thread overview]
Message-ID: <20230314221633.1e6c9bef@kernel.org> (raw)
In-Reply-To: <20230315021850.2788946-3-anjali.k.kulkarni@oracle.com>
On Tue, 14 Mar 2023 19:18:47 -0700 Anjali Kulkarni wrote:
> diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
> index 003c7e6ec9be..ad8ec18152cd 100644
> --- a/net/netlink/af_netlink.c
> +++ b/net/netlink/af_netlink.c
> @@ -63,6 +63,7 @@
> #include <linux/net_namespace.h>
> #include <linux/nospec.h>
> #include <linux/btf_ids.h>
> +#include <linux/connector.h>
Not needed any more.
> /* must not acquire netlink_table_lock in any way again before unbind
> * and notifying genetlink is done as otherwise it might deadlock
> */
> - if (nlk->netlink_unbind) {
> + if (nlk->netlink_unbind && nlk->groups) {
Why?
> int i;
> -
> for (i = 0; i < nlk->ngroups; i++)
> if (test_bit(i, nlk->groups))
> nlk->netlink_unbind(sock_net(sk), i + 1);
Please separate the netlink core changes from the connector
changes.
Please slow down with new versions, we have 300 patches in the queue,
replying to one version just to notice you posted a new one is
frustrating. Give reviewers 24h to reply.
next prev parent reply other threads:[~2023-03-15 5:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-15 2:18 [PATCH v2 0/5] Process connector bug fixes & enhancements Anjali Kulkarni
2023-03-15 2:18 ` [PATCH v2 1/5] netlink: Reverse the patch which removed filtering Anjali Kulkarni
2023-03-15 2:18 ` [PATCH v2 2/5] connector/cn_proc: Add filtering to fix some bugs Anjali Kulkarni
2023-03-15 5:16 ` Jakub Kicinski [this message]
2023-03-15 17:41 ` Anjali Kulkarni
2023-03-16 7:51 ` kernel test robot
2023-03-15 2:18 ` [PATCH v2 3/5] connector/cn_proc: Test code for proc connector Anjali Kulkarni
2023-03-15 2:18 ` [PATCH v2 4/5] connector/cn_proc: Performance improvements Anjali Kulkarni
2023-03-15 2:18 ` [PATCH v2 5/5] connector/cn_proc: Allow non-root users access Anjali Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230314221633.1e6c9bef@kernel.org \
--to=kuba@kernel.org \
--cc=anjali.k.kulkarni@oracle.com \
--cc=brauner@kernel.org \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=johannes@sipsolutions.net \
--cc=keescook@chromium.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=socketcan@hartkopp.net \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).