netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Sven Auhagen <Sven.Auhagen@voleatech.de>
Cc: netdev@vger.kernel.org, mw@semihalf.com, linux@armlinux.org.uk,
	davem@davemloft.net, maxime.chevallier@bootlin.com
Subject: Re: [PATCH 1/3] net: mvpp2: classifier flow remove tagged
Date: Tue, 14 Mar 2023 23:58:53 -0700	[thread overview]
Message-ID: <20230314235853.4dfb1cb6@kernel.org> (raw)
In-Reply-To: <20230311070948.k3jyklkkhnsvngrc@Svens-MacBookPro.local>

On Sat, 11 Mar 2023 08:09:48 +0100 Sven Auhagen wrote:
> The classifier attribute MVPP22_CLS_HEK_TAGGED
> has no effect in the definition and is filtered out by default.

filtered out in the code somewhere? 

> Even if it is applied to the classifier, it would discard double
> or tripple tagged vlans.

So the MVPP22_CLS_HEK_TAGGED change is a nop?

> Also add missing IP Fragmentation Flag.

What's the impact of this change? Seems like it should be a separate
patch.

  reply	other threads:[~2023-03-15  6:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-11  7:09 [PATCH 1/3] net: mvpp2: classifier flow remove tagged Sven Auhagen
2023-03-15  6:58 ` Jakub Kicinski [this message]
2023-03-15  7:56   ` Sven Auhagen
2023-03-15  7:31 ` Maxime Chevallier
2023-03-15  7:53   ` Sven Auhagen
2023-03-15 10:19     ` Maxime Chevallier
2023-03-15 10:29       ` Sven Auhagen
2023-03-15 17:39       ` Sven Auhagen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230314235853.4dfb1cb6@kernel.org \
    --to=kuba@kernel.org \
    --cc=Sven.Auhagen@voleatech.de \
    --cc=davem@davemloft.net \
    --cc=linux@armlinux.org.uk \
    --cc=maxime.chevallier@bootlin.com \
    --cc=mw@semihalf.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).