* [PATCH 2/3] net: mvpp2: parser fix QinQ
@ 2023-03-11 7:10 Sven Auhagen
2023-03-15 7:00 ` Jakub Kicinski
0 siblings, 1 reply; 3+ messages in thread
From: Sven Auhagen @ 2023-03-11 7:10 UTC (permalink / raw)
To: netdev; +Cc: mw, linux, kuba, davem, maxime.chevallier
The mvpp2 parser entry for QinQ has the inner and outer VLAN
in the wrong order.
Fix the problem by swapping them.
Signed-off-by: Sven Auhagen <sven.auhagen@voleatech.de>
diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_prs.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_prs.c
index 75ba57bd1d46..ed8be396428b 100644
--- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_prs.c
+++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_prs.c
@@ -1539,8 +1539,8 @@ static int mvpp2_prs_vlan_init(struct platform_device *pdev, struct mvpp2 *priv)
if (!priv->prs_double_vlans)
return -ENOMEM;
- /* Double VLAN: 0x8100, 0x88A8 */
- err = mvpp2_prs_double_vlan_add(priv, ETH_P_8021Q, ETH_P_8021AD,
+ /* Double VLAN: 0x88A8, 0x8100 */
+ err = mvpp2_prs_double_vlan_add(priv, ETH_P_8021AD, ETH_P_8021Q,
MVPP2_PRS_PORT_MASK);
if (err)
return err;
--
2.33.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 2/3] net: mvpp2: parser fix QinQ
2023-03-11 7:10 [PATCH 2/3] net: mvpp2: parser fix QinQ Sven Auhagen
@ 2023-03-15 7:00 ` Jakub Kicinski
2023-03-15 7:54 ` Sven Auhagen
0 siblings, 1 reply; 3+ messages in thread
From: Jakub Kicinski @ 2023-03-15 7:00 UTC (permalink / raw)
To: Sven Auhagen; +Cc: netdev, mw, linux, davem, maxime.chevallier
On Sat, 11 Mar 2023 08:10:05 +0100 Sven Auhagen wrote:
> The mvpp2 parser entry for QinQ has the inner and outer VLAN
> in the wrong order.
> Fix the problem by swapping them.
>
> Signed-off-by: Sven Auhagen <sven.auhagen@voleatech.de>
Can we get a Fixes tag for this change?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/3] net: mvpp2: parser fix QinQ
2023-03-15 7:00 ` Jakub Kicinski
@ 2023-03-15 7:54 ` Sven Auhagen
0 siblings, 0 replies; 3+ messages in thread
From: Sven Auhagen @ 2023-03-15 7:54 UTC (permalink / raw)
To: Jakub Kicinski; +Cc: netdev, mw, linux, davem, maxime.chevallier
On Wed, Mar 15, 2023 at 12:00:02AM -0700, Jakub Kicinski wrote:
> On Sat, 11 Mar 2023 08:10:05 +0100 Sven Auhagen wrote:
> > The mvpp2 parser entry for QinQ has the inner and outer VLAN
> > in the wrong order.
> > Fix the problem by swapping them.
> >
> > Signed-off-by: Sven Auhagen <sven.auhagen@voleatech.de>
>
> Can we get a Fixes tag for this change?
Yes, I will add it in v2.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-15 7:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-11 7:10 [PATCH 2/3] net: mvpp2: parser fix QinQ Sven Auhagen
2023-03-15 7:00 ` Jakub Kicinski
2023-03-15 7:54 ` Sven Auhagen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).