From: Jakub Kicinski <kuba@kernel.org>
To: Nikolay Aleksandrov <razor@blackwall.org>
Cc: netdev@vger.kernel.org, monis@voltaire.com, syoshida@redhat.com,
j.vosburgh@gmail.com, andy@greyhouse.net, davem@davemloft.net,
pabeni@redhat.com, edumazet@google.com,
syzbot+9dfc3f3348729cc82277@syzkaller.appspotmail.com
Subject: Re: [PATCH net v2 1/4] bonding: add bond_ether_setup helper
Date: Wed, 15 Mar 2023 00:55:57 -0700 [thread overview]
Message-ID: <20230315005557.10e7984f@kernel.org> (raw)
In-Reply-To: <20230314111426.1254998-2-razor@blackwall.org>
On Tue, 14 Mar 2023 13:14:23 +0200 Nikolay Aleksandrov wrote:
> +/* ether_setup() resets bond_dev's flags so we always have to restore
> + * IFF_MASTER, and only restore IFF_SLAVE if it was set
> + */
> +static void bond_ether_setup(struct net_device *bond_dev)
> +{
> + unsigned int slave_flag = bond_dev->flags & IFF_SLAVE;
> +
> + ether_setup(bond_dev);
> + bond_dev->flags |= IFF_MASTER | slave_flag;
> + bond_dev->priv_flags &= ~IFF_TX_SKB_SHARING;
> +}
> +
We can't split this from patch 2, it's going to generate a warning
under normal build flags, people may have WERROR set these days..
next prev parent reply other threads:[~2023-03-15 7:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 11:14 [PATCH net v2 0/4] bonding: properly restore flags when bond changes ether type Nikolay Aleksandrov
2023-03-14 11:14 ` [PATCH net v2 1/4] bonding: add bond_ether_setup helper Nikolay Aleksandrov
2023-03-14 14:58 ` Michal Kubiak
2023-03-14 15:08 ` Nikolay Aleksandrov
2023-03-14 15:12 ` Nikolay Aleksandrov
2023-03-14 15:34 ` Jay Vosburgh
2023-03-14 15:37 ` Nikolay Aleksandrov
2023-03-15 7:55 ` Jakub Kicinski [this message]
2023-03-15 8:21 ` Nikolay Aleksandrov
2023-03-14 11:14 ` [PATCH net v2 2/4] bonding: restore IFF_MASTER/SLAVE flags on bond enslave ether type change Nikolay Aleksandrov
2023-03-14 15:09 ` Michal Kubiak
2023-03-14 15:13 ` Nikolay Aleksandrov
2023-03-14 11:14 ` [PATCH net v2 3/4] bonding: restore bond's IFF_SLAVE flag if a non-eth dev enslave fails Nikolay Aleksandrov
2023-03-14 15:07 ` Michal Kubiak
2023-03-14 11:14 ` [PATCH net v2 4/4] selftests: bonding: add tests for ether type changes Nikolay Aleksandrov
2023-03-14 15:04 ` Michal Kubiak
2023-03-14 15:15 ` [PATCH net v2 0/4] bonding: properly restore flags when bond changes ether type Jonathan Toppins
2023-03-14 16:20 ` Jay Vosburgh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230315005557.10e7984f@kernel.org \
--to=kuba@kernel.org \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=j.vosburgh@gmail.com \
--cc=monis@voltaire.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=syoshida@redhat.com \
--cc=syzbot+9dfc3f3348729cc82277@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).