From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74D68C7619A for ; Wed, 15 Mar 2023 08:50:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231790AbjCOIuA (ORCPT ); Wed, 15 Mar 2023 04:50:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55454 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231752AbjCOIt6 (ORCPT ); Wed, 15 Mar 2023 04:49:58 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 278E219130 for ; Wed, 15 Mar 2023 01:49:55 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A042B61C32 for ; Wed, 15 Mar 2023 08:49:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3F220C433EF; Wed, 15 Mar 2023 08:49:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678870194; bh=1f1GF13OsVmdZUGrxe/AJVGbi2jqhZpmwGQq3XP7yhA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=V2/uowpd0Jop9QVG2Z7/noF9ECrjGBWQboOeeftIeWZhQl2D9R6naX3I/IiRoakZ+ nUb4ac/QuvS34ZhrIDO8i2YNfu59K7RmX36tY2Z4naRdT0aK4+qdw2MwTlEI2/e6Y9 TuCyKLHdlnSRuo1TUxW3MWEoNZ5rgPyq30fLzzSt2+QUVsPk2fHLXE5vkW9fw8PFjP jfgQrQiTqybbcnayhhhmnyXyUH33RzQ0fY8iFAPqmm9DNPDMz9aBwA1L4osq/QDmZz lmCh0tiSvrCNflfcR+e9gu8PQV2N6QB8x+pfS6ITmzpdPX5CYdpOKtaKRcueC5IDF6 ldy1uU4VxXSRw== Date: Wed, 15 Mar 2023 10:49:49 +0200 From: Leon Romanovsky To: Tony Nguyen Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, edumazet@google.com, netdev@vger.kernel.org, Alexander Lobakin , Larysa Zaremba , Michal Kubiak , Rafal Romanowski Subject: Re: [PATCH net 1/3] iavf: fix inverted Rx hash condition leading to disabled hash Message-ID: <20230315084949.GO36557@unreal> References: <20230314174423.1048526-1-anthony.l.nguyen@intel.com> <20230314174423.1048526-2-anthony.l.nguyen@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230314174423.1048526-2-anthony.l.nguyen@intel.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Mar 14, 2023 at 10:44:21AM -0700, Tony Nguyen wrote: > From: Alexander Lobakin > > Condition, which checks whether the netdev has hashing enabled is > inverted. Basically, the tagged commit effectively disabled passing flow > hash from descriptor to skb, unless user *disables* it via Ethtool. > Commit a876c3ba59a6 ("i40e/i40evf: properly report Rx packet hash") > fixed this problem, but only for i40e. > Invert the condition now in iavf and unblock passing hash to skbs again. > > Fixes: 857942fd1aa1 ("i40e: Fix Rx hash reported to the stack by our driver") > Reviewed-by: Larysa Zaremba > Reviewed-by: Michal Kubiak > Signed-off-by: Alexander Lobakin > Tested-by: Rafal Romanowski > Signed-off-by: Tony Nguyen > --- > drivers/net/ethernet/intel/iavf/iavf_txrx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Thanks, Reviewed-by: Leon Romanovsky