From: Jakub Kicinski <kuba@kernel.org>
To: Tony Lu <tonylu@linux.alibaba.com>
Cc: Kai <KaiShen@linux.alibaba.com>,
kgraul@linux.ibm.com, wenjia@linux.ibm.com, jaka@linux.ibm.com,
davem@davemloft.net, netdev@vger.kernel.org,
linux-s390@vger.kernel.org, linux-rdma@vger.kernel.org
Subject: Re: [PATCH net-next v4] net/smc: Use percpu ref for wr tx reference
Date: Wed, 15 Mar 2023 13:40:45 -0700 [thread overview]
Message-ID: <20230315134045.2daeffa4@kernel.org> (raw)
In-Reply-To: <ZBGBWafISbzBapnq@TONYMAC-ALIBABA.local>
On Wed, 15 Mar 2023 16:27:05 +0800 Tony Lu wrote:
> > You're missing a --- separator here, try to apply this patch with
> > git am :/
>
> There is another commit ce7ca794712f ("net/smc: fix fallback failed
> while sendmsg with fastopen") that has been merged that also has this
> problem. Maybe we can add some scripts to check this?
Good idea, checkpatch is probably the right place to complain?
A check along the lines of "if Sign-off-by: has been seen, no
empty lines are allowed until ---"?
Would you be willing to try to code that up and send it to the
checkpatch maintainer? If they refuse we can create a local
check just for networking in our on scripts.
next prev parent reply other threads:[~2023-03-15 20:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-13 6:04 [PATCH net-next v4] net/smc: Use percpu ref for wr tx reference Kai
2023-03-15 7:34 ` Jakub Kicinski
2023-03-15 8:27 ` Tony Lu
2023-03-15 20:40 ` Jakub Kicinski [this message]
2023-03-16 6:37 ` Tony Lu
2023-03-17 2:44 ` Kai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230315134045.2daeffa4@kernel.org \
--to=kuba@kernel.org \
--cc=KaiShen@linux.alibaba.com \
--cc=davem@davemloft.net \
--cc=jaka@linux.ibm.com \
--cc=kgraul@linux.ibm.com \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tonylu@linux.alibaba.com \
--cc=wenjia@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).