From: Jakub Kicinski <kuba@kernel.org>
To: Michal Michalik <michal.michalik@intel.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, pabeni@redhat.com,
edumazet@google.com, arkadiusz.kubalewski@intel.com
Subject: Re: [PATCH net v2] tools: ynl: Add missing types to encode/decode
Date: Wed, 15 Mar 2023 21:43:57 -0700 [thread overview]
Message-ID: <20230315214357.74396015@kernel.org> (raw)
In-Reply-To: <20230315120852.19314-1-michal.michalik@intel.com>
On Wed, 15 Mar 2023 13:08:52 +0100 Michal Michalik wrote:
> While testing the tool I noticed we miss the u16 type on payload create.
> On the code inspection it turned out we miss also u8 and u64 - add them.
>
> We also miss the decoding of u16 despite the fact `NlAttr` class
> supports it - add it.
Do we have any spec upstream which needs these?
The patch looks good, but I think net-next is good enough?
> Fixes: e4b48ed460d3 ("tools: ynl: add a completely generic client")
> Signed-off-by: Michal Michalik <michal.michalik@intel.com>
>
> ---
Please make sure there's no empty lines between the tags and the ---
separator, it confuses the scripts.
next prev parent reply other threads:[~2023-03-16 4:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-15 12:08 [PATCH net v2] tools: ynl: Add missing types to encode/decode Michal Michalik
2023-03-16 4:43 ` Jakub Kicinski [this message]
2023-03-20 19:14 ` Michalik, Michal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230315214357.74396015@kernel.org \
--to=kuba@kernel.org \
--cc=arkadiusz.kubalewski@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=michal.michalik@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).