From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90528C61DA4 for ; Wed, 15 Mar 2023 22:59:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230421AbjCOW7U (ORCPT ); Wed, 15 Mar 2023 18:59:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60398 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232817AbjCOW7C (ORCPT ); Wed, 15 Mar 2023 18:59:02 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2BE7D898D7 for ; Wed, 15 Mar 2023 15:59:01 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id CC8ACB81F93 for ; Wed, 15 Mar 2023 22:58:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 62C11C433EF; Wed, 15 Mar 2023 22:58:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678921138; bh=emD0XWY6TrgG/C8QLiwCv6+1PG8v7XgzUDp8yNRqPDA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DHhmJnjF8kPC3+dZ5Z7TQXIUU3eSP0ODr+n07WldescDfeV2jWhEyRXu6A4pVXr6F UwbqHGYCIZZvuOp3z2QSNF5zhs+G71nGecKWZei+SOcWR74kSbsGv/sVWPjBbWgGqr P+3NXScAzNf6SRCk0vn4DnQjooqRmAh1FL3PIShMfLLBHLVAyuwVtWT19R9Jjoo8zY Rrq3QTT/88LeWJTtgOrQDBbiq6use1nPwcjygGEXknjTDqxqCmoFH35dozeQinLWtF /RckyOK2BPTWnCAbC3vTuk/GyJQuGoNVNnZWvWv2VI+F4asB2bsbSb2QB6Uuu+geP4 EvJpfvJ5YSN4Q== From: Saeed Mahameed To: "David S. Miller" , Jakub Kicinski , Paolo Abeni , Eric Dumazet Cc: Saeed Mahameed , netdev@vger.kernel.org, Tariq Toukan , Oz Shlomo , Dan Carpenter , Paul Blakey Subject: [net V2 12/14] net/mlx5e: TC, fix missing error code Date: Wed, 15 Mar 2023 15:58:45 -0700 Message-Id: <20230315225847.360083-13-saeed@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230315225847.360083-1-saeed@kernel.org> References: <20230315225847.360083-1-saeed@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Oz Shlomo Missing error code when mlx5e_tc_act_stats_create fails Fixes: d13674b1d14c ("net/mlx5e: TC, map tc action cookie to a hw counter") Reported-by: Dan Carpenter Signed-off-by: Oz Shlomo Reviewed-by: Paul Blakey Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c index cc35cbc9934d..d2e191ee0704 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c @@ -5305,8 +5305,10 @@ int mlx5e_tc_nic_init(struct mlx5e_priv *priv) mlx5e_tc_debugfs_init(tc, mlx5e_fs_get_debugfs_root(priv->fs)); tc->action_stats_handle = mlx5e_tc_act_stats_create(); - if (IS_ERR(tc->action_stats_handle)) + if (IS_ERR(tc->action_stats_handle)) { + err = PTR_ERR(tc->action_stats_handle); goto err_act_stats; + } return 0; @@ -5441,8 +5443,10 @@ int mlx5e_tc_esw_init(struct mlx5_rep_uplink_priv *uplink_priv) } uplink_priv->action_stats_handle = mlx5e_tc_act_stats_create(); - if (IS_ERR(uplink_priv->action_stats_handle)) + if (IS_ERR(uplink_priv->action_stats_handle)) { + err = PTR_ERR(uplink_priv->action_stats_handle); goto err_action_counter; + } return 0; -- 2.39.2