From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EADBC7618A for ; Wed, 15 Mar 2023 22:59:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232932AbjCOW7V (ORCPT ); Wed, 15 Mar 2023 18:59:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60754 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232904AbjCOW7F (ORCPT ); Wed, 15 Mar 2023 18:59:05 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A069AA3B7C for ; Wed, 15 Mar 2023 15:59:02 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 40716B81F0D for ; Wed, 15 Mar 2023 22:59:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D09B9C4339C; Wed, 15 Mar 2023 22:58:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678921139; bh=Bd8Q5pVMvPKmAKc3xq4HHKfaGanAptQxR/jkHp5knMk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JSrp3srehCiPrjXXdHt2Ou9eVTOo5qVA12rgoV+SJkgzEBfM3en0olno9kibXWEPY lPMi3XSm8NMTnwTBAI2OaHC1beEwl849+Pnhs+rceXmQbkWneleKEUDnf9FIpAFRCJ XBUsJ3QWHyRO963mStbxMwwjnNbki5VOQ3OVx9SbyET8S/QoM1XQT5iVhoHLWaRDA+ cgXuNbMfzZhXusQDHeE4e34kGTH8GceJJ3T6jBvcvp/KOwf6/A7Qgw+6TkXH9D0pgA Og8PJGW15Zajv1Dzf/04dMpd+kPNlZmv/CJA2J8P4j1qlsXhbeLeliGBHW0ruwfjTA dhKmanbPpyHOg== From: Saeed Mahameed To: "David S. Miller" , Jakub Kicinski , Paolo Abeni , Eric Dumazet Cc: Saeed Mahameed , netdev@vger.kernel.org, Tariq Toukan , Oz Shlomo , Paul Blakey Subject: [net V2 14/14] net/mlx5e: TC, Remove error message log print Date: Wed, 15 Mar 2023 15:58:47 -0700 Message-Id: <20230315225847.360083-15-saeed@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230315225847.360083-1-saeed@kernel.org> References: <20230315225847.360083-1-saeed@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Oz Shlomo The cited commit attempts to update the hw stats when dumping tc actions. However, the driver may be called to update the stats of a police action that may not be in hardware. In such cases the driver will fail to lookup the police action object and will output an error message both to extack and dmesg. The dmesg error is confusing as it may not indicate an actual error. Remove the dmesg error. Fixes: 2b68d659a704 ("net/mlx5e: TC, support per action stats") Signed-off-by: Oz Shlomo Reviewed-by: Paul Blakey Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en/tc/act/police.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/tc/act/police.c b/drivers/net/ethernet/mellanox/mlx5/core/en/tc/act/police.c index c4378afdec09..1bd1c94fb977 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en/tc/act/police.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/tc/act/police.c @@ -178,7 +178,6 @@ tc_act_police_stats(struct mlx5e_priv *priv, meter = mlx5e_tc_meter_get(priv->mdev, ¶ms); if (IS_ERR(meter)) { NL_SET_ERR_MSG_MOD(fl_act->extack, "Failed to get flow meter"); - mlx5_core_err(priv->mdev, "Failed to get flow meter %d\n", params.index); return PTR_ERR(meter); } -- 2.39.2