From: Sumitra Sharma <sumitraartsy@gmail.com>
To: Dan Carpenter <error27@gmail.com>
Cc: outreachy@lists.linux.dev, manishc@marvell.com,
GR-Linux-NIC-Dev@marvell.com, coiby.xu@gmail.com,
gregkh@linuxfoundation.org, netdev@vger.kernel.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] Staging: qlge: Fix indentation in conditional statement
Date: Thu, 16 Mar 2023 01:14:28 -0700 [thread overview]
Message-ID: <20230316081428.GA47053@sumitra.com> (raw)
In-Reply-To: <6e12c373-2bfd-48d8-b77d-17f710c094f7@kili.mountain>
On Wed, Mar 15, 2023 at 10:47:21AM +0300, Dan Carpenter wrote:
> On Tue, Mar 14, 2023 at 05:11:52AM -0700, Sumitra Sharma wrote:
> > Add tabs/spaces in conditional statements in to fix the
> > indentation.
> >
> > Signed-off-by: Sumitra Sharma <sumitraartsy@gmail.com>
> >
> > ---
> > v2: Fix indentation in conditional statement, noted by Dan Carpenter
> > <error27@gmail.com>
> > v3: Apply changes to fresh git tree
> >
>
> Thanks!
>
> Reviewed-by: Dan Carpenter <error27@gmail.com>
>
Hi dan,
Will this be considered as my first accepted patch? :)
Regards,
Sumitra
> regards,
> dan carpenter
>
next prev parent reply other threads:[~2023-03-16 8:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 12:11 [PATCH v3] Staging: qlge: Fix indentation in conditional statement Sumitra Sharma
2023-03-15 7:47 ` Dan Carpenter
2023-03-16 8:14 ` Sumitra Sharma [this message]
2023-03-16 8:27 ` Julia Lawall
2023-03-18 1:36 ` Ira Weiny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230316081428.GA47053@sumitra.com \
--to=sumitraartsy@gmail.com \
--cc=GR-Linux-NIC-Dev@marvell.com \
--cc=coiby.xu@gmail.com \
--cc=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=manishc@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).