From: Jakub Kicinski <kuba@kernel.org>
To: Ahmed Zaki <ahmed.zaki@intel.com>
Cc: Leon Romanovsky <leon@kernel.org>,
Tony Nguyen <anthony.l.nguyen@intel.com>, <davem@davemloft.net>,
<pabeni@redhat.com>, <edumazet@google.com>,
<netdev@vger.kernel.org>, Michal Kubiak <michal.kubiak@intel.com>,
Rafal Romanowski <rafal.romanowski@intel.com>
Subject: Re: [PATCH net 3/3] iavf: do not track VLAN 0 filters
Date: Thu, 16 Mar 2023 13:59:24 -0700 [thread overview]
Message-ID: <20230316135924.4ece7127@kernel.org> (raw)
In-Reply-To: <bf4ce937-8528-69f1-7ba5-ef9772ce42aa@intel.com>
On Thu, 16 Mar 2023 07:15:32 -0600 Ahmed Zaki wrote:
> > I would expect similar check in iavf_vlan_rx_kill_vid(),
>
> Thanks for review. Next version will include the check in
> iavf_vlan_rx_kill_vid()
FWIW it is okay to ask more clarifying questions / push back
a little. I had a quick look and calling iavf_vlan_rx_kill_vid()
with vid of 0 does not seem harmful. Or any vid that was not added
earlier. So it's down to personal preference. I see v2 is already
out but just for future reference..
next prev parent reply other threads:[~2023-03-16 20:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 17:44 [PATCH net 0/3][pull request] Intel Wired LAN Driver Updates 2023-03-14 (iavf) Tony Nguyen
2023-03-14 17:44 ` [PATCH net 1/3] iavf: fix inverted Rx hash condition leading to disabled hash Tony Nguyen
2023-03-15 8:49 ` Leon Romanovsky
2023-03-14 17:44 ` [PATCH net 2/3] iavf: fix non-tunneled IPv6 UDP packet type and hashing Tony Nguyen
2023-03-15 8:50 ` Leon Romanovsky
2023-03-14 17:44 ` [PATCH net 3/3] iavf: do not track VLAN 0 filters Tony Nguyen
2023-03-15 8:48 ` Leon Romanovsky
2023-03-16 13:15 ` Ahmed Zaki
2023-03-16 20:59 ` Jakub Kicinski [this message]
2023-03-16 21:11 ` Ahmed Zaki
2023-03-19 7:20 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230316135924.4ece7127@kernel.org \
--to=kuba@kernel.org \
--cc=ahmed.zaki@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=leon@kernel.org \
--cc=michal.kubiak@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rafal.romanowski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).