From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70ACEC6FD19 for ; Thu, 16 Mar 2023 15:55:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231208AbjCPPzA (ORCPT ); Thu, 16 Mar 2023 11:55:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57704 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230470AbjCPPy6 (ORCPT ); Thu, 16 Mar 2023 11:54:58 -0400 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E62967D090 for ; Thu, 16 Mar 2023 08:54:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678982097; x=1710518097; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=zMPqyXc+JucbCeEHIgjQIHVKs3JnbPHDq+essdBpBss=; b=m48NtxyvjLEXytNaOJk1eYSmUHYu6ddcZZouBk7cR/0HYgX4jCL7H5jC Egrtkg1/h/nQZ344mx0Wk4n2h/Zm4CCl/qxnffsvGWlVjXfliQDsu+n4k RtgJ6m7H6Rx5gOF08TLOK+YIDgMnoCMfyEksHRDZk4znTxmbvurGHL6St KrEfb5eVN5ZWwgpf1VU9P9MgxUrCi8EKaysa8H5YyfB7O2ZM8cKWGtp3B 3ENPyNhH18wxAXOCxZu9V1JpKUqGrxUGKC8zCbKezAH0h3gYnbLoEIJKU GuBumWM/RkijNh99ep5C25Cx3zGfHVEpS8BuH9zpUE9UGyiTMnxgORtUi g==; X-IronPort-AV: E=McAfee;i="6600,9927,10651"; a="340406431" X-IronPort-AV: E=Sophos;i="5.98,265,1673942400"; d="scan'208";a="340406431" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2023 08:54:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10651"; a="769010296" X-IronPort-AV: E=Sophos;i="5.98,265,1673942400"; d="scan'208";a="769010296" Received: from anguy11-upstream.jf.intel.com ([10.166.9.133]) by FMSMGA003.fm.intel.com with ESMTP; 16 Mar 2023 08:54:57 -0700 From: Tony Nguyen To: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, edumazet@google.com, netdev@vger.kernel.org Cc: Alexander Lobakin , anthony.l.nguyen@intel.com, leonro@nvidia.com, Larysa Zaremba , Michal Kubiak , Rafal Romanowski Subject: [PATCH net v2 1/3] iavf: fix inverted Rx hash condition leading to disabled hash Date: Thu, 16 Mar 2023 08:53:14 -0700 Message-Id: <20230316155316.1554931-2-anthony.l.nguyen@intel.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230316155316.1554931-1-anthony.l.nguyen@intel.com> References: <20230316155316.1554931-1-anthony.l.nguyen@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Alexander Lobakin Condition, which checks whether the netdev has hashing enabled is inverted. Basically, the tagged commit effectively disabled passing flow hash from descriptor to skb, unless user *disables* it via Ethtool. Commit a876c3ba59a6 ("i40e/i40evf: properly report Rx packet hash") fixed this problem, but only for i40e. Invert the condition now in iavf and unblock passing hash to skbs again. Fixes: 857942fd1aa1 ("i40e: Fix Rx hash reported to the stack by our driver") Reviewed-by: Larysa Zaremba Reviewed-by: Michal Kubiak Signed-off-by: Alexander Lobakin Tested-by: Rafal Romanowski Reviewed-by: Leon Romanovsky Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/iavf/iavf_txrx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/iavf/iavf_txrx.c b/drivers/net/ethernet/intel/iavf/iavf_txrx.c index 18b6a702a1d6..e989feda133c 100644 --- a/drivers/net/ethernet/intel/iavf/iavf_txrx.c +++ b/drivers/net/ethernet/intel/iavf/iavf_txrx.c @@ -1096,7 +1096,7 @@ static inline void iavf_rx_hash(struct iavf_ring *ring, cpu_to_le64((u64)IAVF_RX_DESC_FLTSTAT_RSS_HASH << IAVF_RX_DESC_STATUS_FLTSTAT_SHIFT); - if (ring->netdev->features & NETIF_F_RXHASH) + if (!(ring->netdev->features & NETIF_F_RXHASH)) return; if ((rx_desc->wb.qword1.status_error_len & rss_mask) == rss_mask) { -- 2.38.1