From: Jakub Kicinski <kuba@kernel.org>
To: Michal Kubiak <michal.kubiak@intel.com>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net] i825xx: sni_82596: use eth_hw_addr_set()
Date: Thu, 16 Mar 2023 17:36:35 -0700 [thread overview]
Message-ID: <20230316173635.049ee5f4@kernel.org> (raw)
In-Reply-To: <ZBIKcx6/77aePZUE@localhost.localdomain>
On Wed, 15 Mar 2023 19:12:03 +0100 Michal Kubiak wrote:
> The fix looks fine. Good catch!
> I would only suggest to add more description why it needed to be
> changed.
> (The current version of the commit message only contains information what
> was done, but it is quite obvious by looking at the code).
Let me make an exception and add that info myself.. since I broke this
:)
next prev parent reply other threads:[~2023-03-17 0:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-15 13:41 [PATCH net] i825xx: sni_82596: use eth_hw_addr_set() Thomas Bogendoerfer
2023-03-15 18:12 ` Michal Kubiak
2023-03-17 0:36 ` Jakub Kicinski [this message]
2023-03-17 0:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230316173635.049ee5f4@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.kubiak@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).