From: Jakub Kicinski <kuba@kernel.org>
To: joshwash@google.com
Cc: netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH net] gve: Cache link_speed value from device
Date: Thu, 16 Mar 2023 17:42:27 -0700 [thread overview]
Message-ID: <20230316174227.6f38803a@kernel.org> (raw)
In-Reply-To: <20230315174016.4193015-1-joshwash@google.com>
On Wed, 15 Mar 2023 10:40:16 -0700 joshwash@google.com wrote:
> From: Joshua Washington <joshwash@google.com>
>
> The link speed is never changed for the uptime of a VM. Caching the
> value will allow for better performance.
>
> Fixes: 7e074d5a76ca ("gve: Enable Link Speed Reporting in the driver.")
If it needs to go in as a fix / to stable we need a bit more info about
the nature of the problem. What user-visible (or hypervisor-visible)
impact will be? What entity needs link info so often that it becomes
a problem?
The code looks fine as an optimization, i.e. for net-next, but you say
"PATCH net" and there's a Fixes tag...
next prev parent reply other threads:[~2023-03-17 0:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-15 17:40 [PATCH net] gve: Cache link_speed value from device joshwash
2023-03-17 0:42 ` Jakub Kicinski [this message]
2023-03-17 0:43 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230316174227.6f38803a@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=joshwash@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).