From: Jakub Kicinski <kuba@kernel.org>
To: Ronak Doshi <doshir@vmware.com>
Cc: Yunsheng Lin <linyunsheng@huawei.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
Pv-drivers <Pv-drivers@vmware.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Guolin Yang <gyang@vmware.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net] vmxnet3: use gro callback when UPT is enabled
Date: Fri, 17 Mar 2023 19:43:39 -0700 [thread overview]
Message-ID: <20230317194339.67a33db1@kernel.org> (raw)
In-Reply-To: <754F4F49-97C9-45D3-9B2F-C7DAE3FFC30E@vmware.com>
On Fri, 17 Mar 2023 20:27:50 +0000 Ronak Doshi wrote:
> I don’t think holding this patch to investigate why it takes longer in GRO is worthwhile.
> That is a separate issue. UPT patches are already upstreamed to Linux and cross-ported to
> relevant distros for customers to use. We need to apply this patch to avoid the performance
> degradation in UPT mode as LRO is not available on UPT device.
>
> I don’t see a functional issue with this patch. In UPT as LRO is not available, it needs to use GRO.
Fine by me, FWIW, but please respin the patch and feed some of
the discussion into the commit message.
next prev parent reply other threads:[~2023-03-18 2:43 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-08 22:25 [PATCH net] vmxnet3: use gro callback when UPT is enabled Ronak Doshi
2023-03-09 0:34 ` Yunsheng Lin
2023-03-09 22:50 ` Ronak Doshi
2023-03-10 1:02 ` Yunsheng Lin
2023-03-14 21:09 ` Ronak Doshi
2023-03-15 1:51 ` Yunsheng Lin
2023-03-15 2:27 ` Ronak Doshi
2023-03-15 3:04 ` Yunsheng Lin
2023-03-15 23:44 ` Ronak Doshi
2023-03-16 1:47 ` Yunsheng Lin
2023-03-16 4:03 ` Ronak Doshi
2023-03-16 4:13 ` Jakub Kicinski
2023-03-16 5:21 ` Ronak Doshi
2023-03-16 20:34 ` Jakub Kicinski
2023-03-17 2:37 ` Yunsheng Lin
2023-03-17 20:27 ` Ronak Doshi
2023-03-18 2:43 ` Jakub Kicinski [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-03-23 5:43 Ronak Doshi
2023-03-23 15:48 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230317194339.67a33db1@kernel.org \
--to=kuba@kernel.org \
--cc=Pv-drivers@vmware.com \
--cc=davem@davemloft.net \
--cc=doshir@vmware.com \
--cc=edumazet@google.com \
--cc=gyang@vmware.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linyunsheng@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).