From: Jakub Kicinski <kuba@kernel.org>
To: Donald Hunter <donald.hunter@redhat.com>
Cc: Donald Hunter <donald.hunter@gmail.com>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net-next v1 2/2] netlink: specs: add partial specification for openvswitch
Date: Sat, 18 Mar 2023 18:44:20 -0700 [thread overview]
Message-ID: <20230318184420.4046574c@kernel.org> (raw)
In-Reply-To: <CAAf2ycne3nQ4Y_-tNihgMMtmDiNtQ7o7bGMjojrEUBJR_JsHMA@mail.gmail.com>
On Sat, 18 Mar 2023 16:54:35 +0000 Donald Hunter wrote:
> > On Thu, 16 Mar 2023 12:01:42 +0000 Donald Hunter wrote:
> > > +user-header: ovs_header
> >
> > Let's place this attr inside 'operations'?
>
> Ah, good point - can it vary per operation and should it be a property
> of each command?
We should allow both. Have tools/net/ynl/lib/nlspec.py expose it as
a property of an operation, but let the spec writers only specify
it once if each command uses the same format.
prev parent reply other threads:[~2023-03-19 1:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-16 12:01 [PATCH net-next v1 0/2] ynl: add support for user headers and struct attrs Donald Hunter
2023-03-16 12:01 ` [PATCH net-next v1 1/2] tools: ynl: add user-header and struct attr support Donald Hunter
2023-03-18 4:50 ` Jakub Kicinski
2023-03-18 16:46 ` Donald Hunter
2023-03-16 12:01 ` [PATCH net-next v1 2/2] netlink: specs: add partial specification for openvswitch Donald Hunter
2023-03-18 4:52 ` Jakub Kicinski
2023-03-18 16:54 ` Donald Hunter
2023-03-19 1:44 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230318184420.4046574c@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=donald.hunter@redhat.com \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).