From: Vladimir Oltean <olteanv@gmail.com>
To: "Marek Behún" <marek.behun@nic.cz>
Cc: Klaus Kudielka <klaus.kudielka@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Richard Cochran <richardcochran@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v4 4/4] net: dsa: mv88e6xxx: mask apparently non-existing phys during probing
Date: Sun, 19 Mar 2023 15:34:07 +0200 [thread overview]
Message-ID: <20230319133407.xb6k2uxcy52a5pzl@skbuf> (raw)
In-Reply-To: <20230319110606.23e30050@thinkpad>
On Sun, Mar 19, 2023 at 11:06:06AM +0100, Marek Behún wrote:
> > + bus->phy_mask = GENMASK(31, mv88e6xxx_num_ports(chip));
>
> shouldnt this be
> GENMASK(31, mv88e6xxx_num_ports(chip) + chip->info->phy_base_addr) |
> GENMASK(chip->info->phy_base_addr, 0)
> ?
> Or alternatively
> ~GENMASK(chip->info->phy_base_addr + mv88e6xxx_num_ports(chip),
> chip->info->phy_base_addr)
Good point. Would you mind sending a patch? I prefer the second variant BTW.
next prev parent reply other threads:[~2023-03-19 13:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-15 16:38 [PATCH net-next v4 0/4] net: dsa: mv88e6xxx: accelerate C45 scan Klaus Kudielka
2023-03-15 16:38 ` [PATCH net-next v4 1/4] net: dsa: mv88e6xxx: don't dispose of Global2 IRQ mappings from mdiobus code Klaus Kudielka
2023-03-17 15:30 ` Vladimir Oltean
2023-03-17 17:06 ` Florian Fainelli
2023-03-15 16:38 ` [PATCH net-next v4 2/4] net: dsa: mv88e6xxx: re-order functions Klaus Kudielka
2023-03-17 15:31 ` Vladimir Oltean
2023-03-17 17:07 ` Florian Fainelli
2023-03-15 16:38 ` [PATCH net-next v4 3/4] net: dsa: mv88e6xxx: move call to mv88e6xxx_mdios_register() Klaus Kudielka
2023-03-17 15:32 ` Vladimir Oltean
2023-03-17 17:07 ` Florian Fainelli
2023-03-15 16:38 ` [PATCH net-next v4 4/4] net: dsa: mv88e6xxx: mask apparently non-existing phys during probing Klaus Kudielka
2023-03-17 15:33 ` Vladimir Oltean
2023-03-17 17:07 ` Florian Fainelli
2023-03-19 10:06 ` Marek Behún
2023-03-19 13:34 ` Vladimir Oltean [this message]
2023-03-19 13:35 ` Vladimir Oltean
2023-03-18 5:40 ` [PATCH net-next v4 0/4] net: dsa: mv88e6xxx: accelerate C45 scan patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230319133407.xb6k2uxcy52a5pzl@skbuf \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=klaus.kudielka@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marek.behun@nic.cz \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox