From: Alex Williamson <alex.williamson@redhat.com>
To: Heiko Carstens <hca@linux.ibm.com>
Cc: Lizhe <sensor1010@163.com>,
wintera@linux.ibm.com, wenjia@linux.ibm.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
linux-s390@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] net/iucv: Remove redundant driver match function
Date: Mon, 20 Mar 2023 10:20:56 -0600 [thread overview]
Message-ID: <20230320102056.1be1fcf7.alex.williamson@redhat.com> (raw)
In-Reply-To: <ZBdtn0wFunrkvml9@osiris>
On Sun, 19 Mar 2023 21:16:31 +0100
Heiko Carstens <hca@linux.ibm.com> wrote:
> On Sun, Mar 19, 2023 at 01:08:40PM +0800, Lizhe wrote:
> > If there is no driver match function, the driver core assumes that each
> > candidate pair (driver, device) matches, see driver_match_device().
> >
> > Drop the bus's match function that always returned 1 and so
> > implements the same behaviour as when there is no match function
> ...
> >
> > Signed-off-by: Lizhe <sensor1010@163.com>
> > ---
> > net/iucv/iucv.c | 6 ------
> > 1 file changed, 6 deletions(-)
> ...
> > -static int iucv_bus_match(struct device *dev, struct device_driver *drv)
> > -{
> > - return 0;
> ^^^^^^^^
>
> If I'm not wrong then 0 != 1.
>
Seems like an unchecked patch bot, proposed an identical bad patch for
vfio/mdev. Thanks,
Alex
prev parent reply other threads:[~2023-03-20 16:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-19 5:08 [PATCH v1] net/iucv: Remove redundant driver match function Lizhe
2023-03-19 20:16 ` Heiko Carstens
2023-03-20 16:20 ` Alex Williamson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230320102056.1be1fcf7.alex.williamson@redhat.com \
--to=alex.williamson@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hca@linux.ibm.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sensor1010@163.com \
--cc=wenjia@linux.ibm.com \
--cc=wintera@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).