From: Jakub Kicinski <kuba@kernel.org>
To: Stanislav Fomichev <sdf@google.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com
Subject: Re: [PATCH net-next 2/4] ynl: populate most of the ethtool spec
Date: Mon, 20 Mar 2023 11:59:10 -0700 [thread overview]
Message-ID: <20230320115910.50374a67@kernel.org> (raw)
In-Reply-To: <CAKH8qBvkFvyyPwah7uDiJP2tm7k4NZ10Kgw2ykDs8jqOs4gXtg@mail.gmail.com>
On Mon, 20 Mar 2023 11:03:33 -0700 Stanislav Fomichev wrote:
> On Fri, Mar 17, 2023 at 9:33 PM Jakub Kicinski <kuba@kernel.org> wrote:
> > On Fri, 17 Mar 2023 17:23:38 -0700 Stanislav Fomichev wrote:
> > > Things that are not implemented:
> > > - cable tests
> > > - bitmaks in the requests don't work (needs multi-attr support in ynl.py)
> > > - stats-get seems to return nonsense
> >
> > Hm. What kind of nonsense?
>
> {'grp': {'id': 1, 'ss-id': 18}}
>
> But I guess that's because I'm not passing the group bitmask correctly?
Hm, or the driver you're trying does not have any _structured_ stats?
Does
ethtool -S \* --all-groups
show anything? Note that these are not all the old ethtool -S stats.
> > > - notifications are not tested
> > > - features-nft has hard-coded value:13, not sure why it skews
> >
> > ETHTOOL_MSG_FEATURES_SET_REPLY exists but there is no reply:
> > section in the spec.
>
> Ah, good catch, I guess something like this would do? It doesn't have
> to be a new empty msg?
> reply:
> attributes: *feature
Oh right, there's an actual reply to features. I thought it was just
reserved but we need to return to the user space what we managed to
set and what we didn't. Makes sense.
next prev parent reply other threads:[~2023-03-20 19:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-18 0:23 [PATCH net-next 0/4] ynl: fill in some gaps of ethtool spec Stanislav Fomichev
2023-03-18 0:23 ` [PATCH net-next 1/4] ynl: support be16 in schemas Stanislav Fomichev
2023-03-18 4:18 ` Jakub Kicinski
2023-03-20 18:03 ` Stanislav Fomichev
2023-03-18 0:23 ` [PATCH net-next 2/4] ynl: populate most of the ethtool spec Stanislav Fomichev
2023-03-18 4:33 ` Jakub Kicinski
2023-03-20 18:03 ` Stanislav Fomichev
2023-03-20 18:59 ` Jakub Kicinski [this message]
2023-03-18 0:23 ` [PATCH net-next 3/4] ynl: replace print with NlError Stanislav Fomichev
2023-03-18 4:21 ` Jakub Kicinski
2023-03-20 18:03 ` Stanislav Fomichev
2023-03-20 18:53 ` Jakub Kicinski
2023-03-18 0:23 ` [PATCH net-next 4/4] ynl: ethtool testing tool Stanislav Fomichev
2023-03-18 4:23 ` Jakub Kicinski
2023-03-20 18:03 ` Stanislav Fomichev
2023-03-18 4:24 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230320115910.50374a67@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).