From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7B05C6FD1D for ; Tue, 21 Mar 2023 04:42:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229583AbjCUEmN (ORCPT ); Tue, 21 Mar 2023 00:42:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48838 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229483AbjCUEmM (ORCPT ); Tue, 21 Mar 2023 00:42:12 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E588D30181 for ; Mon, 20 Mar 2023 21:42:10 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 948F5B80CA0 for ; Tue, 21 Mar 2023 04:42:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A743CC433D2; Tue, 21 Mar 2023 04:42:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679373728; bh=996goaCyWTUhF7iaI5iHtEeigGPkASBDWBYfXXitPIk=; h=From:To:Cc:Subject:Date:From; b=DFcRJaxL0QKg6I0CT1HdQ1iAXDojSUSkYfH757gfE6y3LG9/G9WQ3eHODjbNrevxj 2vL6seZUOuRgYMAgNcZdTq9bryM2Tx77KwTc2eWfKbnjbhGyuXzvXYs+rUwYgdopG3 r6dqCk7QVb0WGGZnsqVlXlTFOjtIS1i94z//390JY7KPMpqZQ2S/YmJjfjoi8r+LD5 pqkZcTKjTw8C2pseqUBx5UPu/8JAfrJkkozebFhdD/fsnQVKNHEBu23Pm1LK8yz92O wqnUidl6BgArsgawvjAekTz4HINk0TZvz/DEq0pV5S5gwWupwJb4KHsa7EKa3dOOHZ 0LTBA7mUX/+6Q== From: Jakub Kicinski To: davem@davemloft.net Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com, jiri@resnulli.us, Jakub Kicinski Subject: [PATCH net-next] tools: ynl: skip the explicit op array size when no needed Date: Mon, 20 Mar 2023 21:41:59 -0700 Message-Id: <20230321044159.1031040-1-kuba@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Jiri suggests it reads more naturally to skip the explicit array size when possible. When we export the symbol we want to make sure that the size is right. Signed-off-by: Jakub Kicinski --- net/core/netdev-genl-gen.c | 2 +- tools/net/ynl/ynl-gen-c.py | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/net/core/netdev-genl-gen.c b/net/core/netdev-genl-gen.c index 3abab70d66dd..de17ca2f7dbf 100644 --- a/net/core/netdev-genl-gen.c +++ b/net/core/netdev-genl-gen.c @@ -16,7 +16,7 @@ static const struct nla_policy netdev_dev_get_nl_policy[NETDEV_A_DEV_IFINDEX + 1 }; /* Ops table for netdev */ -static const struct genl_split_ops netdev_nl_ops[2] = { +static const struct genl_split_ops netdev_nl_ops[] = { { .cmd = NETDEV_CMD_DEV_GET, .doit = netdev_nl_dev_get_doit, diff --git a/tools/net/ynl/ynl-gen-c.py b/tools/net/ynl/ynl-gen-c.py index c16671a02621..972b87c7aaaf 100755 --- a/tools/net/ynl/ynl-gen-c.py +++ b/tools/net/ynl/ynl-gen-c.py @@ -1696,7 +1696,9 @@ _C_KW = { 'split': 'genl_split_ops'} struct_type = pol_to_struct[family.kernel_policy] - if family.kernel_policy == 'split': + if not exported: + cnt = "" + elif family.kernel_policy == 'split': cnt = 0 for op in family.ops.values(): if 'do' in op: -- 2.39.2