From: Jakub Kicinski <kuba@kernel.org>
To: "Michalik, Michal" <michal.michalik@intel.com>
Cc: Edward Cree <ecree.xilinx@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"edumazet@google.com" <edumazet@google.com>,
"Kubalewski, Arkadiusz" <arkadiusz.kubalewski@intel.com>
Subject: Re: [PATCH net] tools: ynl: add the Python requirements.txt file
Date: Tue, 21 Mar 2023 10:52:03 -0700 [thread overview]
Message-ID: <20230321105203.0dfc7a00@kernel.org> (raw)
In-Reply-To: <BN6PR11MB41770D6527882D26403EF628E3819@BN6PR11MB4177.namprd11.prod.outlook.com>
On Tue, 21 Mar 2023 12:34:50 +0000 Michalik, Michal wrote:
> > Assuming the libraries are following best practice for their version
> > numbering (e.g. semver), you should be able to use ~= ('compatible
> > version' [1]).
> > For example, `jsonschema ~= 4.0` will allow any 4.x.y release, but
> > not 5.0.0 since that could have breaking API changes.
> > I would recommend against pinning to a specific version of a
> > dependency; this is a development tree, not a deployment script.
>
> This is actually a good idea. Let's wait for Jakub to confirm if he feels
> the Python requirements file is a good idea in this case. If he confirms,
> I would update the libraries according to your suggestion. Thanks.
Given the "system script" nature of the project (vs "full application")
I don't find the requirements to be necessary right now. But I don't
know much about Python, so maybe Ed can make a call? :D
next prev parent reply other threads:[~2023-03-21 17:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 16:07 [PATCH net] tools: ynl: add the Python requirements.txt file Michal Michalik
2023-03-16 4:40 ` Jakub Kicinski
2023-03-20 19:03 ` Michalik, Michal
2023-03-20 22:16 ` Edward Cree
2023-03-21 12:34 ` Michalik, Michal
2023-03-21 17:52 ` Jakub Kicinski [this message]
2023-03-21 18:52 ` Edward Cree
2023-03-23 10:33 ` Michalik, Michal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230321105203.0dfc7a00@kernel.org \
--to=kuba@kernel.org \
--cc=arkadiusz.kubalewski@intel.com \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=michal.michalik@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).