From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C14A9C6FD1D for ; Tue, 21 Mar 2023 17:52:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229912AbjCURwU (ORCPT ); Tue, 21 Mar 2023 13:52:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47550 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229834AbjCURwT (ORCPT ); Tue, 21 Mar 2023 13:52:19 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B116B532B6 for ; Tue, 21 Mar 2023 10:52:05 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 400F961D79 for ; Tue, 21 Mar 2023 17:52:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 58726C433D2; Tue, 21 Mar 2023 17:52:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679421124; bh=nkNp6dCDLADE//B1wXaWjXqjWuenmND8o37eqNTrhjk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Nvps22nrCN/mVFQUqPasDaVwSFtCbdX2B85RoYos+mjcvmzNm0JiPVA41I0EVUhTz 7j1udc8CcfA7PJTKJ+Q0l2qbq7532mo0jPGMU+2sjjArvQTuFQTiQgQiQXs3fuLRoB aG6nYGa49si5V55hE3rgo9Bn6pzVNN/2+w0A4s7oEpbLqcV+8g/qjuaMGMQY3bxMr0 u1xNhegA/Xu4UB3NtJYOtTxEQaa8LSQ4Fs3Ei/JxKtiN5ZP3Mxs2Y6iXp8674TKkEx 6ZGS54lDvrgeXEqRjQltj4u1ymjb69TrFSyBLKmWlwulQwOS60LCysHeWQxw+hClMV QMWEP7AwijN0g== Date: Tue, 21 Mar 2023 10:52:03 -0700 From: Jakub Kicinski To: "Michalik, Michal" Cc: Edward Cree , "netdev@vger.kernel.org" , "davem@davemloft.net" , "pabeni@redhat.com" , "edumazet@google.com" , "Kubalewski, Arkadiusz" Subject: Re: [PATCH net] tools: ynl: add the Python requirements.txt file Message-ID: <20230321105203.0dfc7a00@kernel.org> In-Reply-To: References: <20230314160758.23719-1-michal.michalik@intel.com> <20230315214008.2536a1b4@kernel.org> <560bd227-e0a9-5c01-29d8-1b71dc42f155@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 21 Mar 2023 12:34:50 +0000 Michalik, Michal wrote: > > Assuming the libraries are following best practice for their version > > numbering (e.g. semver), you should be able to use ~= ('compatible > > version' [1]). > > For example, `jsonschema ~= 4.0` will allow any 4.x.y release, but > > not 5.0.0 since that could have breaking API changes. > > I would recommend against pinning to a specific version of a > > dependency; this is a development tree, not a deployment script. > > This is actually a good idea. Let's wait for Jakub to confirm if he feels > the Python requirements file is a good idea in this case. If he confirms, > I would update the libraries according to your suggestion. Thanks. Given the "system script" nature of the project (vs "full application") I don't find the requirements to be necessary right now. But I don't know much about Python, so maybe Ed can make a call? :D