From: David Vernet <void@manifault.com>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: davem@davemloft.net, daniel@iogearbox.net, andrii@kernel.org,
martin.lau@kernel.org, davemarchevsky@meta.com, tj@kernel.org,
memxor@gmail.com, netdev@vger.kernel.org, bpf@vger.kernel.org,
kernel-team@fb.com
Subject: Re: [PATCH v2 bpf-next 1/4] libbpf: Rename RELO_EXTERN_VAR/FUNC.
Date: Tue, 21 Mar 2023 17:12:49 -0500 [thread overview]
Message-ID: <20230321221249.GA239208@maniforge> (raw)
In-Reply-To: <20230321203854.3035-2-alexei.starovoitov@gmail.com>
On Tue, Mar 21, 2023 at 01:38:51PM -0700, Alexei Starovoitov wrote:
> From: Alexei Starovoitov <ast@kernel.org>
>
> RELO_EXTERN_VAR/FUNC names are not correct anymore. RELO_EXTERN_VAR represent
> ksym symbol in ld_imm64 insn. It can point to kernel variable or kfunc.
> Rename RELO_EXTERN_VAR->RELO_EXTERN_LD64 and RELO_EXTERN_FUNC->RELO_EXTERN_CALL
> to match what they actually represent.
>
> Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Acked-by: David Vernet <void@manifault.com>
next prev parent reply other threads:[~2023-03-21 22:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 20:38 [PATCH v2 bpf-next 0/4] bpf: Support ksym detection in light skeleton Alexei Starovoitov
2023-03-21 20:38 ` [PATCH v2 bpf-next 1/4] libbpf: Rename RELO_EXTERN_VAR/FUNC Alexei Starovoitov
2023-03-21 22:12 ` David Vernet [this message]
2023-03-21 20:38 ` [PATCH v2 bpf-next 2/4] bpf: Teach the verifier to recognize rdonly_mem as not null Alexei Starovoitov
2023-03-21 22:21 ` David Vernet
2023-03-21 20:38 ` [PATCH v2 bpf-next 3/4] libbpf: Support kfunc detection in light skeleton Alexei Starovoitov
2023-03-21 20:38 ` [PATCH v2 bpf-next 4/4] selftests/bpf: Add light skeleton test for kfunc detection Alexei Starovoitov
2023-03-22 16:40 ` [PATCH v2 bpf-next 0/4] bpf: Support ksym detection in light skeleton patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230321221249.GA239208@maniforge \
--to=void@manifault.com \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=davemarchevsky@meta.com \
--cc=kernel-team@fb.com \
--cc=martin.lau@kernel.org \
--cc=memxor@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).