From: Jakub Kicinski <kuba@kernel.org>
To: Min Li <lnimi@hotmail.com>
Cc: richardcochran@gmail.com, lee@kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Min Li <min.li.xe@renesas.com>
Subject: Re: [PATCH mfd 1/1] mfd/ptp: clockmatrix: support 32-bit address space
Date: Wed, 22 Mar 2023 12:56:19 -0700 [thread overview]
Message-ID: <20230322125619.731912cf@kernel.org> (raw)
In-Reply-To: <MW5PR03MB69323E281F1360A4F6C92838A0819@MW5PR03MB6932.namprd03.prod.outlook.com>
On Tue, 21 Mar 2023 15:10:06 -0400 Min Li wrote:
> - buf[0] = (u8)(page & 0xff);
> - buf[1] = (u8)((page >> 8) & 0xff);
> + buf[0] = (u8)(page & 0xFF);
> + buf[1] = (u8)((page >> 8) & 0xFF);
why did you decide to change from 0xff to 0xFF as part of this big
change? It's unnecessary churn.
> + buf[2] = (u8)((page >> 16) & 0xFF);
> + buf[3] = (u8)((page >> 24) & 0xFF);
> + bytes = 4;
> break;
> static inline int idtcm_read(struct idtcm *idtcm,
> - u16 module,
> + u32 module,
> u16 regaddr,
> u8 *buf,
> u16 count)
> @@ -50,7 +50,7 @@ static inline int idtcm_read(struct idtcm *idtcm,
> }
>
> static inline int idtcm_write(struct idtcm *idtcm,
> - u16 module,
> + u32 module,
> u16 regaddr,
> u8 *buf,
> u16 count)
> /* PLL5 can have OUT8 as second additional output. */
> if (pll == 5 && qn_plus_1 != 0) {
> - err = idtcm_read(idtcm, 0, HW_Q8_CTRL_SPARE,
> + err = idtcm_read(idtcm, HW_Q8_CTRL_SPARE, 0,
> &temp, sizeof(temp));
> if (err)
> return err;
>
> temp &= ~(Q9_TO_Q8_SYNC_TRIG);
>
> - err = idtcm_write(idtcm, 0, HW_Q8_CTRL_SPARE,
> + err = idtcm_write(idtcm, HW_Q8_CTRL_SPARE, 0,
> &temp, sizeof(temp));
> if (err)
> return err;
>
> temp |= Q9_TO_Q8_SYNC_TRIG;
>
> - err = idtcm_write(idtcm, 0, HW_Q8_CTRL_SPARE,
> + err = idtcm_write(idtcm, HW_Q8_CTRL_SPARE, 0,
> &temp, sizeof(temp));
> if (err)
> return err;
Why are you flipping all these arguments?
Isn't HW_Q8_CTRL_SPARE regaddr?
Could you to split your patches into multiple steps to make them easier
to reivew?
next prev parent reply other threads:[~2023-03-22 19:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 19:10 [PATCH mfd 1/1] mfd/ptp: clockmatrix: support 32-bit address space Min Li
2023-03-22 19:56 ` Jakub Kicinski [this message]
2023-03-23 2:46 ` Richard Cochran
2023-03-23 14:18 ` Min Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230322125619.731912cf@kernel.org \
--to=kuba@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lnimi@hotmail.com \
--cc=min.li.xe@renesas.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).