From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD036C6FD1C for ; Wed, 22 Mar 2023 20:11:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231947AbjCVULe (ORCPT ); Wed, 22 Mar 2023 16:11:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50460 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231600AbjCVUKw (ORCPT ); Wed, 22 Mar 2023 16:10:52 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 58C137DF9C; Wed, 22 Mar 2023 13:03:44 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 388D5622D9; Wed, 22 Mar 2023 20:02:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 98096C433EF; Wed, 22 Mar 2023 20:02:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679515334; bh=lvQnkhV/8wk805PIcWa9w3sPtixMKH2N/WGyitj9tfc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IPNHHb2QUoSz1YE6fMXlNKttssHHum+tcNQy/vqBx6WTgN8y64FeGEmg6TVYxeJ0W rbKu9ByP7zlcvki+4okjcwa3g9iYyy7ncI6WM8C32PKldeI3eFAcCM1DPDX6iKxZbZ zviXUenzHfBUTatq6ALmLohphvDiu1e0CyzbvGO2DYy8HJcEKleDLINcchTzTq1258 KCTsJw4VuHJ7RK/XMHGA25OGI5N1ijj8ouV/KTR0gP6h4W5aqNcxnKh1F68CEglYdo 1NeDG5eXr7vizJeYsRYjt0WajtiZ7uDZceva7YYzmjLilZNxXiM/n9OTxXO+hpaqQt 7qabJMxqLT3rw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Kristian Overskeid , "David S . Miller" , Sasha Levin , edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, bigeasy@linutronix.de, kurt@linutronix.de, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 5.10 02/12] net: hsr: Don't log netdev_err message on unknown prp dst node Date: Wed, 22 Mar 2023 16:01:56 -0400 Message-Id: <20230322200207.1997367-2-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230322200207.1997367-1-sashal@kernel.org> References: <20230322200207.1997367-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Kristian Overskeid [ Upstream commit 28e8cabe80f3e6e3c98121576eda898eeb20f1b1 ] If no frames has been exchanged with a node for HSR_NODE_FORGET_TIME, the node will be deleted from the node_db list. If a frame is sent to the node after it is deleted, a netdev_err message for each slave interface is produced. This should not happen with dan nodes because of supervision frames, but can happen often with san nodes, which clutters the kernel log. Since the hsr protocol does not support sans, this is only relevant for the prp protocol. Signed-off-by: Kristian Overskeid Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- net/hsr/hsr_framereg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/hsr/hsr_framereg.c b/net/hsr/hsr_framereg.c index 20cb6b7dbc694..08627c8368848 100644 --- a/net/hsr/hsr_framereg.c +++ b/net/hsr/hsr_framereg.c @@ -380,7 +380,7 @@ void hsr_addr_subst_dest(struct hsr_node *node_src, struct sk_buff *skb, node_dst = find_node_by_addr_A(&port->hsr->node_db, eth_hdr(skb)->h_dest); if (!node_dst) { - if (net_ratelimit()) + if (net_ratelimit() && port->hsr->prot_version != PRP_V1) netdev_err(skb->dev, "%s: Unknown node\n", __func__); return; } -- 2.39.2