From: Jakub Kicinski <kuba@kernel.org>
To: Min Li <lnimi@hotmail.com>
Cc: richardcochran@gmail.com, lee@kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Min Li <min.li.xe@renesas.com>
Subject: Re: [PATCH mfd-n 2/2] mfd: rsmu: support 32-bit address space
Date: Thu, 23 Mar 2023 09:57:36 -0700 [thread overview]
Message-ID: <20230323095736.38ea1ca8@kernel.org> (raw)
In-Reply-To: <MW5PR03MB69320CC31AB6206419DFF2C9A0879@MW5PR03MB6932.namprd03.prod.outlook.com>
On Thu, 23 Mar 2023 12:15:18 -0400 Min Li wrote:
> - u8 cmd[256] = {0};
> - u8 rsp[256] = {0};
> + u8 cmd[RSMU_MAX_READ_COUNT + 1] = {0};
> + u8 rsp[RSMU_MAX_READ_COUNT + 1] = {0};
> int ret;
>
> + if (bytes > RSMU_MAX_READ_COUNT)
> + return -EINVAL;
Why is defining the constant to MAX_READ and checking the requested
size part of this patch, the commit message only talks about addresses
operation size is not mentioned in any way...
prev parent reply other threads:[~2023-03-23 16:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230323161518.14907-1-lnimi@hotmail.com>
2023-03-23 16:15 ` [PATCH mfd-n 2/2] mfd: rsmu: support 32-bit address space Min Li
2023-03-23 16:57 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230323095736.38ea1ca8@kernel.org \
--to=kuba@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lnimi@hotmail.com \
--cc=min.li.xe@renesas.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).