From: Jakub Kicinski <kuba@kernel.org>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-kernel@vger.kernel.org,
Simon Horman <simon.horman@corigine.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Steve Glendinning <steve.glendinning@shawell.net>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Vladimir Oltean <olteanv@gmail.com>
Subject: Re: [PATCH net v3 1/2] smsc911x: only update stats when interface is up
Date: Thu, 23 Mar 2023 11:39:45 -0700 [thread overview]
Message-ID: <20230323113945.0915029d@kernel.org> (raw)
In-Reply-To: <20230322071959.9101-2-wsa+renesas@sang-engineering.com>
On Wed, 22 Mar 2023 08:19:58 +0100 Wolfram Sang wrote:
> - smsc911x_tx_update_txcounters(dev);
> - dev->stats.rx_dropped += smsc911x_reg_read(pdata, RX_DROP);
> +
> + if (netif_running(dev)) {
> + smsc911x_tx_update_txcounters(dev);
> + dev->stats.rx_dropped += smsc911x_reg_read(pdata, RX_DROP);
> + }
Same problem as on the renesas patch, netif_running() can return true
before ndo->open() is called. And stats can be read with just the RCU
lock (via procfs).
Maybe we should add a false-negative version of netif_running() ?
__LINK_STATE_START*ED* ?
next prev parent reply other threads:[~2023-03-23 18:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 7:19 [PATCH net v3 0/2] smsc911x: fix issues when interface is not up yet Wolfram Sang
2023-03-22 7:19 ` [PATCH net v3 1/2] smsc911x: only update stats when interface is up Wolfram Sang
2023-03-23 18:39 ` Jakub Kicinski [this message]
2023-03-24 7:33 ` Wolfram Sang
2023-03-22 7:19 ` [PATCH net v3 2/2] smsc911x: avoid PHY being resumed when interface is not up Wolfram Sang
2023-03-22 20:20 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230323113945.0915029d@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=geert+renesas@glider.be \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=simon.horman@corigine.com \
--cc=steve.glendinning@shawell.net \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).