From: Matthieu Baerts <matthieu.baerts@tessares.net>
To: mptcp@lists.linux.dev, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Shuah Khan <shuah@kernel.org>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org,
Matthieu Baerts <matthieu.baerts@tessares.net>
Subject: [PATCH net-next v2 1/4] mptcp: avoid unneeded address copy
Date: Mon, 27 Mar 2023 12:22:21 +0200 [thread overview]
Message-ID: <20230324-upstream-net-next-20230324-misc-features-v2-1-fca1471efbaa@tessares.net> (raw)
In-Reply-To: <20230324-upstream-net-next-20230324-misc-features-v2-0-fca1471efbaa@tessares.net>
From: Paolo Abeni <pabeni@redhat.com>
In the syn_recv fallback path, the msk is unused. We can skip
setting the socket address.
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Reviewed-by: Matthieu Baerts <matthieu.baerts@tessares.net>
Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net>
---
net/mptcp/subflow.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/net/mptcp/subflow.c b/net/mptcp/subflow.c
index dadaf85db720..a11f4c525e01 100644
--- a/net/mptcp/subflow.c
+++ b/net/mptcp/subflow.c
@@ -821,8 +821,6 @@ static struct sock *subflow_syn_recv_sock(const struct sock *sk,
goto dispose_child;
}
- if (new_msk)
- mptcp_copy_inaddrs(new_msk, child);
mptcp_subflow_drop_ctx(child);
goto out;
}
--
2.39.2
next prev parent reply other threads:[~2023-03-27 10:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 10:22 [PATCH net-next v2 0/4] mptcp: a couple of cleanups and improvements Matthieu Baerts
2023-03-27 10:22 ` Matthieu Baerts [this message]
2023-03-27 10:22 ` [PATCH net-next v2 2/4] mptcp: simplify subflow_syn_recv_sock() Matthieu Baerts
2023-03-27 10:22 ` [PATCH net-next v2 3/4] mptcp: do not fill info not used by the PM in used Matthieu Baerts
2023-03-27 10:22 ` [PATCH net-next v2 4/4] selftests: mptcp: add mptcp_info tests Matthieu Baerts
2023-03-29 8:10 ` [PATCH net-next v2 0/4] mptcp: a couple of cleanups and improvements patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230324-upstream-net-next-20230324-misc-features-v2-1-fca1471efbaa@tessares.net \
--to=matthieu.baerts@tessares.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).